[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/11] hw/hppa/machine: Restrict the total memory size to 3GB
From: |
Richard Henderson |
Subject: |
[PULL 09/11] hw/hppa/machine: Restrict the total memory size to 3GB |
Date: |
Tue, 21 Jan 2020 16:32:54 -1000 |
From: Philippe Mathieu-Daudé <address@hidden>
The hardware expects DIMM slots of 1 or 2 GB, allowing up to
4 GB of memory. We want to accept the same amount of memory the
hardware can deal with. DIMMs of 768MB are not available.
However we have to deal with a firmware limitation: currently
SeaBIOS only supports 32-bit, and expects the RAM size in a
32-bit register. When using a 4GB configuration, the 32-bit
register get truncated and we report a size of 0MB to SeaBIOS,
which ends halting the machine:
$ qemu-system-hppa -m 4g -serial stdio
SeaBIOS: Machine configured with too little memory (0 MB), minimum is 16 MB.
SeaBIOS wants SYSTEM HALT.
The easiest way is to restrict the machine to 3GB of memory.
Acked-by: Helge Deller <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/hppa/machine.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index e57530950a..57cb4e0f34 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -92,12 +92,11 @@ static void machine_hppa_init(MachineState *machine)
g_free(name);
}
- /* Limit main memory. */
- if (ram_size > FIRMWARE_START) {
- machine->ram_size = ram_size = FIRMWARE_START;
- }
-
/* Main memory region. */
+ if (machine->ram_size > 3 * GiB) {
+ error_report("RAM size is currently restricted to 3GB");
+ exit(EXIT_FAILURE);
+ }
ram_region = g_new(MemoryRegion, 1);
memory_region_allocate_system_memory(ram_region, OBJECT(machine),
"ram", ram_size);
--
2.20.1
- [PULL 00/11] target/hppa patch queue, Richard Henderson, 2020/01/21
- [PULL 01/11] hw/hppa/dino.c: Improve emulation of Dino PCI chip, Richard Henderson, 2020/01/21
- [PULL 03/11] ps2: accept 'Set Key Make and Break' commands, Richard Henderson, 2020/01/21
- [PULL 05/11] hppa: Switch to tulip NIC by default, Richard Henderson, 2020/01/21
- [PULL 04/11] hppa: add emulation of LASI PS2 controllers, Richard Henderson, 2020/01/21
- [PULL 02/11] hppa: Add support for LASI chip with i82596 NIC, Richard Henderson, 2020/01/21
- [PULL 08/11] hw/hppa/machine: Correctly check the firmware is in PDC range, Richard Henderson, 2020/01/21
- [PULL 09/11] hw/hppa/machine: Restrict the total memory size to 3GB,
Richard Henderson <=
- [PULL 07/11] hppa: Add emulation of Artist graphics, Richard Henderson, 2020/01/21
- [PULL 10/11] hw/hppa/machine: Map the PDC memory region with higher priority, Richard Henderson, 2020/01/21
- [PULL 11/11] target/hppa: Allow, but diagnose, LDCW aligned only mod 4, Richard Henderson, 2020/01/21
- Re: [PULL 00/11] target/hppa patch queue, Richard Henderson, 2020/01/21
- [PULL 06/11] seabios-hppa: update to latest version, Richard Henderson, 2020/01/21
- Re: [PULL 00/11] target/hppa patch queue, no-reply, 2020/01/21