[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locke
From: |
Alistair Francis |
Subject: |
Re: [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked |
Date: |
Tue, 21 Jan 2020 08:56:48 +1000 |
On Thu, Jan 9, 2020 at 12:55 PM Richard Henderson
<address@hidden> wrote:
>
> No functional change, but the smaller expressions make
> the code easier to read.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> accel/tcg/cputlb.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index c7dc1dc85a..eff427f137 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -230,15 +230,16 @@ static void tlb_mmu_resize_locked(CPUTLBDesc *desc,
> CPUTLBDescFast *fast)
>
> static void tlb_flush_one_mmuidx_locked(CPUArchState *env, int mmu_idx)
> {
> - tlb_mmu_resize_locked(&env_tlb(env)->d[mmu_idx],
> &env_tlb(env)->f[mmu_idx]);
> - env_tlb(env)->d[mmu_idx].n_used_entries = 0;
> - env_tlb(env)->d[mmu_idx].large_page_addr = -1;
> - env_tlb(env)->d[mmu_idx].large_page_mask = -1;
> - env_tlb(env)->d[mmu_idx].vindex = 0;
> - memset(env_tlb(env)->f[mmu_idx].table, -1,
> - sizeof_tlb(&env_tlb(env)->f[mmu_idx]));
> - memset(env_tlb(env)->d[mmu_idx].vtable, -1,
> - sizeof(env_tlb(env)->d[0].vtable));
> + CPUTLBDesc *desc = &env_tlb(env)->d[mmu_idx];
> + CPUTLBDescFast *fast = &env_tlb(env)->f[mmu_idx];
> +
> + tlb_mmu_resize_locked(desc, fast);
> + desc->n_used_entries = 0;
> + desc->large_page_addr = -1;
> + desc->large_page_mask = -1;
> + desc->vindex = 0;
> + memset(fast->table, -1, sizeof_tlb(fast));
> + memset(desc->vtable, -1, sizeof(desc->vtable));
> }
>
> static inline void tlb_n_used_entries_inc(CPUArchState *env, uintptr_t
> mmu_idx)
> --
> 2.20.1
>
>
- Re: [PATCH 3/9] cputlb: Pass CPUTLBDescFast to tlb_n_entries and sizeof_tlb, (continued)
- [PATCH 4/9] cputlb: Hoist tlb portions in tlb_mmu_resize_locked, Richard Henderson, 2020/01/08
- [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked, Richard Henderson, 2020/01/08
- [PATCH 7/9] cputlb: Partially merge tlb_dyn_init into tlb_init, Richard Henderson, 2020/01/08
- [PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked, Richard Henderson, 2020/01/08
- [PATCH 8/9] cputlb: Initialize tlbs as flushed, Richard Henderson, 2020/01/08