Re: [PATCH 2/4] tests/tcg/aarch64: Fix compilation parameters for pauth-%

[Peter Maydell]

On Thu, 16 Jan 2020 at 23:08, Richard Henderson
<address@hidden> wrote:
>
> Hiding the required architecture within asm() is not correct.
> Add it to the cflags of the (cross-) compiler.

This commit message implies that we're just moving the architecture
specification from the asm statements to the cflags, but the
patch also changes the requested value from v8.4-a to v8.3-a.

I plan to tweak the commit message to be a bit clearer:

We were incorrectly requiring ARMv8.4 support for the pauth
tests, but Pointer Authentication is an ARMv8.3 extension.
Further, hiding the required architecture within asm() is
not correct.

Correct the architecture version requested, and specify it
in the cflags of the (cross-) compiler rather than in the asm.


thanks
-- PMM