qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/6] Makefile: Remove unhelpful comment


From: Alex Bennée
Subject: Re: [PATCH v2 4/6] Makefile: Remove unhelpful comment
Date: Mon, 20 Jan 2020 11:04:02 +0000
User-agent: mu4e 1.3.6; emacs 28.0.50

Philippe Mathieu-Daudé <address@hidden> writes:

> It is pointless to keep qapi/ object separate from the other
> common-objects. Drop the comment.
>
> Reviewed-by: Thomas Huth <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  Makefile.objs | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 395dd1e670..c6321d0465 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -71,11 +71,9 @@ qemu-seccomp.o-libs := $(SECCOMP_LIBS)
>  
>  common-obj-$(CONFIG_FDT) += device_tree.o
>  
> -######################################################################
> -# qapi
> -
>  common-obj-y += qapi/
> -endif
> +
> +endif # CONFIG_SOFTMMU
>  
>  #######################################################################
>  # Target-independent parts used in system and user emulation


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]