Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards

[Philippe Mathieu-Daudé]

Hi Michael,

On 12/30/19 7:17 PM, Michael Rolnik wrote:
> Hi Philippe.
> 
> Thank you for joining the effort.

Could you test this series?

Are you OK if we use the Arduino machines it introduces to replace your
'sample' board?

> Regards,
> Michael Rolnik
> 
> 
> On Mon, Dec 30, 2019 at 12:45 AM Philippe Mathieu-Daudé <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Hi,
> 
>     This series add the arduino boards, aiming at removing the
>     'sample' board that doesn't follow any specification.
> 
>     Since v2:
>     - rebased on Michael's v40
> 
>     Since v1:
>     - Addressed Igor comments
>     - Addressed Aleksandar comments
>     - Fixed UART issue (was due to IRQ shifted by 2 in CPU)
> 
>     TODO after merge is:
>     - Extract Timer8 common parts from Timer16
>     - Add GPIOs
>     - Connect LED to GPIO on Arduino
>     - Plug to Scratch (See http://s4a.cat/).
>       (I plan to purpose that as a GSoC idea).
> 
>     Michael, thank you for having insisted with this port during so long!
> 
>     Regards,
> 
>     Phil.
> 
>     Series available at https://gitlab.com/philmd/qemu/commits/arduino-v3
> 
>     Regards,
> 
>     Phil.
> 
>     Based-on: <address@hidden
>     <mailto:address@hidden>>
>     https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05309.html
> 
>     Philippe Mathieu-Daudé (8):
>       hw/char/avr: Reduce USART I/O size
>       hw/timer/avr_timer16: Rename memory region debugging name
>       hw/avr: Add some ATmega microcontrollers
>       hw/avr: Add some Arduino boards
>       tests/boot-serial-test: Test some Arduino boards (AVR based)
>       tests/acceptance: Do not set the machine type manually
>       tests/acceptance: Keep multilines comment consistent with other tests
>       tests/acceptance: Test the Arduino MEGA2560 board
> 
>      hw/avr/atmega.h                  |  48 ++++
>      hw/avr/arduino.c                 | 177 ++++++++++++
>      hw/avr/atmega.c                  | 464 +++++++++++++++++++++++++++++++
>      hw/char/avr_usart.c              |   2 +-
>      hw/timer/avr_timer16.c           |   6 +-
>      tests/boot-serial-test.c         |   2 +
>      hw/avr/Makefile.objs             |   2 +
>      tests/acceptance/machine_avr6.py |  11 +-
>      8 files changed, 701 insertions(+), 11 deletions(-)
>      create mode 100644 hw/avr/atmega.h
>      create mode 100644 hw/avr/arduino.c
>      create mode 100644 hw/avr/atmega.c
> 
>     -- 
>     2.21.0
> 
> 
> 
> -- 
> Best Regards,
> Michael Rolnik