|
From: | Guenter Roeck |
Subject: | Re: [PATCH 6/6] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330 |
Date: | Sat, 18 Jan 2020 07:08:49 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/17/20 10:44 AM, Peter Maydell wrote:
On Fri, 17 Jan 2020 at 18:29, Guenter Roeck <address@hidden> wrote:
[ ... ]
Rather than having the uart and pl330 pointers be locals, they should be fields in Exynos4210State. (Otherwise technically we leak them, though this is unnoticeable in practice because there's no way to destroy an Exynos4210State.)Out of curiosity: Is that a new leak because they are now tied together, or is it an existing leak ? I don't find many DeviceState entries in xxxState structures, so find it difficult to determine if/when/why there is such a leak.Yes, it's an existing leak, though it's more of a conceptual leak
Do only the pointers have to be in Exynos4210State, or the entire data structures ? In the armsse code it looks like it is the complete data structures. Also, it seems to me that this means that not only pl330 and uart states are affected, but everything created with qdev_create(). If so, the entire file needs a serious rework, not just its pl330 / uart initialization. Am I missing something ? Thanks, Guenter
[Prev in Thread] | Current Thread | [Next in Thread] |