[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/15] target/arm: Set ISSIs16Bit in make_issinfo
From: |
Peter Maydell |
Subject: |
[PULL 15/15] target/arm: Set ISSIs16Bit in make_issinfo |
Date: |
Fri, 17 Jan 2020 14:28:16 +0000 |
From: Richard Henderson <address@hidden>
During the conversion to decodetree, the setting of
ISSIs16Bit got lost. This causes the guest os to
incorrectly adjust trapping memory operations.
Cc: address@hidden
Fixes: 46beb58efbb8a2a32 ("target/arm: Convert T16, load (literal)")
Reported-by: Jeff Kubascik <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
target/arm/translate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 0c8624fb42e..2f4aea927f1 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -8556,6 +8556,9 @@ static ISSInfo make_issinfo(DisasContext *s, int rd, bool
p, bool w)
/* ISS not valid if writeback */
if (p && !w) {
ret = rd;
+ if (s->base.pc_next - s->pc_curr == 2) {
+ ret |= ISSIs16Bit;
+ }
} else {
ret = ISSInvalid;
}
--
2.20.1
- [PULL 04/15] hw/arm: Add the Netduino Plus 2, (continued)
- [PULL 04/15] hw/arm: Add the Netduino Plus 2, Peter Maydell, 2020/01/17
- [PULL 05/15] tests/boot_linux_console: Add initrd test for the CubieBoard, Peter Maydell, 2020/01/17
- [PULL 08/15] hw/arm/allwinner-a10: Simplify by passing IRQs with qdev_pass_gpios(), Peter Maydell, 2020/01/17
- [PULL 07/15] hw/arm/allwinner-a10: Move SoC definitions out of header, Peter Maydell, 2020/01/17
- [PULL 06/15] tests/boot_linux_console: Add a SD card test for the CubieBoard, Peter Maydell, 2020/01/17
- [PULL 09/15] hw/arm/allwinner-a10: Remove local qemu_irq variables, Peter Maydell, 2020/01/17
- [PULL 10/15] target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle, Peter Maydell, 2020/01/17
- [PULL 12/15] target/arm: adjust program counter for wfi exception in AArch32, Peter Maydell, 2020/01/17
- [PULL 11/15] i.MX: add an emulation for RNGC, Peter Maydell, 2020/01/17
- [PULL 14/15] target/arm: Return correct IL bit in merge_syn_data_abort, Peter Maydell, 2020/01/17
- [PULL 15/15] target/arm: Set ISSIs16Bit in make_issinfo,
Peter Maydell <=
- [PULL 13/15] arm/gicv3: update virtual irq state after IAR register read, Peter Maydell, 2020/01/17
- Re: [PULL 00/15] target-arm queue, Peter Maydell, 2020/01/17