qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize


From: Eric Blake
Subject: Re: [PATCH v6 04/11] hw/sd/ssi-sd: fix error handling in ssi_sd_realize
Date: Fri, 17 Jan 2020 08:26:36 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1

On 1/10/20 1:41 PM, Vladimir Sementsov-Ogievskiy wrote:
It's wrong to use same err object as errp parameter for several
function calls without intermediate checking for error: we'll crash if
try to set err object twice.

Fix that, using new ERRP_AUTO_PROPAGATE macro.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
  hw/sd/ssi-sd.c | 26 +++++++++++++++++++-------
  1 file changed, 19 insertions(+), 7 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]