Re: [PATCH v3 0/2] Fix hyperv synic on vhost

[Dr. David Alan Gilbert]

* address@hidden (address@hidden) wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: address@hidden
> Type: series
> Subject: [PATCH v3 0/2] Fix hyperv synic on vhost
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> f7aeff2 vhost: Only align sections for vhost-user
> 5bb467f vhost: Add names to section rounded warning
> 
> === OUTPUT BEGIN ===
> 1/2 Checking commit 5bb467f4ac3b (vhost: Add names to section rounded warning)
> 2/2 Checking commit f7aeff24a99a (vhost: Only align sections for vhost-user)
> ERROR: trailing whitespace
> #45: FILE: hw/virtio/vhost.c:554:
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   $
> 
> WARNING: line over 80 characters
> #60: FILE: hw/virtio/vhost.c:569:
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, 
> mrs_size,
> 
> total: 1 errors, 1 warnings, 43 lines checked

Oops, minor whitespace; easy to fix if people actually like this fix.

Dave

> Patch 2/2 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK