[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address
From: |
gengdongjiu |
Subject: |
Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address |
Date: |
Fri, 17 Jan 2020 18:47:53 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 2020/1/17 15:39, Philippe Mathieu-Daudé wrote:
>> table_offsets = g_array_new(false, true /* clear */,
>> sizeof(uint32_t));
>> @@ -831,7 +832,9 @@ void virt_acpi_build(VirtMachineState *vms,
>> AcpiBuildTables *tables)
>> acpi_add_table(table_offsets, tables_blob);
>> build_spcr(tables_blob, tables->linker, vms);
>> - if (vms->ras) {
>> + acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED,
>> + NULL));
>
> Testing vms->ras first is cheaper than calling object_resolve_path_type().
> Since some people are spending lot of time to reduce VM boot time, it might
> be worth considering.
Thanks Philippe's comments.
Do you think it should be written to below[1]? right?
[1]:
if (vms->ras && acpi_ged_state)
>
>> + if (acpi_ged_state && vms->ras) {
>> acpi_add_table(table_offsets, tables_blob);
>> build_ghes_error_table(tables->hardware_errors, tables->linker);
>> acpi_build_hest(tables_blob, tables->hardware_errors,
>> @@ -925,6 +928,7 @@ void virt_acpi_setup(VirtMachineState *vms)
>> {
- [PATCH v22 0/9] Add ARMv8 RAS virtualization support in QEMU, Dongjiu Geng, 2020/01/08
- [PATCH v22 1/9] hw/arm/virt: Introduce a RAS machine option, Dongjiu Geng, 2020/01/08
- [PATCH v22 6/9] KVM: Move hwpoison page related functions into kvm-all.c, Dongjiu Geng, 2020/01/08
- [PATCH v22 2/9] docs: APEI GHES generation and CPER record description, Dongjiu Geng, 2020/01/08
- [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address, Dongjiu Geng, 2020/01/08
- Re: [PATCH v22 5/9] ACPI: Record the Generic Error Status Block address, Igor Mammedov, 2020/01/28
- [PATCH v22 8/9] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, Dongjiu Geng, 2020/01/08
[PATCH v22 4/9] ACPI: Build Hardware Error Source Table, Dongjiu Geng, 2020/01/08