[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/2] target/arm: Return correct IL bit in merge_syn_data_abort
From: |
Richard Henderson |
Subject: |
[PATCH v2 1/2] target/arm: Return correct IL bit in merge_syn_data_abort |
Date: |
Thu, 16 Jan 2020 14:46:17 -1000 |
From: Jeff Kubascik <address@hidden>
The IL bit is set for 32-bit instructions, thus passing false
with the is_16bit parameter to syn_data_abort_with_iss() makes
a syn mask that always has the IL bit set.
Pass is_16bit as true to make the initial syn mask have IL=0,
so that the final IL value comes from or'ing template_syn.
Cc: address@hidden
Fixes: aaa1f954d4ca ("target-arm: A64: Create Instruction Syndromes for Data
Aborts")
Signed-off-by: Jeff Kubascik <address@hidden>
[rth: Extracted this as a self-contained bug fix from a larger patch]
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/tlb_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
index 5feb312941..e63f8bda29 100644
--- a/target/arm/tlb_helper.c
+++ b/target/arm/tlb_helper.c
@@ -44,7 +44,7 @@ static inline uint32_t merge_syn_data_abort(uint32_t
template_syn,
syn = syn_data_abort_with_iss(same_el,
0, 0, 0, 0, 0,
ea, 0, s1ptw, is_write, fsc,
- false);
+ true);
/* Merge the runtime syndrome with the template syndrome. */
syn |= template_syn;
}
--
2.20.1