Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

[Philippe Mathieu-Daudé]

On 1/16/20 11:16 AM, Daniel P. Berrangé wrote:
> On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote:
> > The GdkMonitor was introduced in GTK+ 3.22:
> > https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22
> >
> > If we build with older GTK+, the build fails:
>
> Presumably the problem here is Ubuntu Xenial 16.04 which
> only has 3.18.9 ?

Indeed:

  $ lsb_release -a
  No LSB modules are available.
  Distributor ID: Ubuntu
  Description:    Ubuntu 16.04.5 LTS
  Release:        16.04
  Codename:       xenial

  $ pkg-config --modversion gtk+-3.0
  3.18.9

> We should put in a sanity check for this against our min version
>
>   #define  GDK_VERSION_MIN_REQUIRED GDK_VERSION_3_14
>   #define  GDK_VERSION_MAX_ALLOWED GDK_VERSION_3_14
>
> into glib-compat.h
>
> For that matter we can update our min version to 3.18 I believe
> since that looks like the oldest version any supported build
> platform has.
>
> Regards,
> Daniel