Re: [kvm-unit-tests PATCH v2 13/16] arm/arm64: ITS: INT functional tests

[Andrew Jones]

On Wed, Jan 15, 2020 at 06:11:23PM +0100, Auger Eric wrote:
> >> +static int its_prerequisites(int nb_cpus)
> >> +{
> >> +  int cpu;
> >> +
> >> +  if (!gicv3_its_base()) {
> >> +          report_skip("No ITS, skip ...");
> >> +          return -1;
> >> +  }
> >> +
> >> +  if (nr_cpus < 4) {
> >> +          report_skip("Test requires at least %d vcpus", nb_cpus);
> >> +          return -1;
> > 
> > We have nr_cpu_check() in arm/gic.c that does a report_abort for this
> > case. Is there a reason to do report_skip instead of report_abort?
> Why should we mandate 4 vcpus?

I don't know. It's your test :-) afaict if there aren't 4 vcpus then you
skip this test and exit, which is the same thing as report_abort'ing.
If you intend to run multiple tests and only want to skip a few when there
aren't enough vcpus, then I agree report_skip makes some sense.

On a related note, so far I've always tried to write tests that require
more than one vcpu to be testable with only two, but then test even more
if more are provided. Do you really need four for this test?

Thanks,
drew