[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 12/22] target/arm: generate xml description of our SVE reg
From: |
Richard Henderson |
Subject: |
Re: [PATCH v5 12/22] target/arm: generate xml description of our SVE registers |
Date: |
Wed, 15 Jan 2020 12:16:18 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/14/20 5:09 AM, Alex Bennée wrote:
> We also expose a the helpers to read/write the the registers.
>
> Signed-off-by: Alex Bennée <address@hidden>
>
> ---
> v2
> - instead of zNpM expose zN at sve_max_vq width
> - wrap union in union q(us), d(usf), s(usf), h(usf), b(us)
> v3
> - add a vg pseudo register for current width
> - spacing fixes
> - use switch/case for whole group
> - drop fpsr_pos marker
> - remove unused variables
> v4
> - const-ify vec_lanes
> - drop vg
Sigh. This still feels like we're coding to a gdb bug.
I assert that vg (or equivalent information) is required for the job to be done
correctly. It's a per-core and therefore, for user-space, per-thread quantity.
We cannot possibly be "changing targets" for the "thread N" command.
I'll give you an
Acked-by: Richard Henderson <address@hidden>
because I recognize that this is how gdb works today, but I don't like it.
r~
- [PATCH v5 03/22] gdbstub: move str_buf to GDBState and use GString, (continued)
- [PATCH v5 03/22] gdbstub: move str_buf to GDBState and use GString, Alex Bennée, 2020/01/14
- [PATCH v5 07/22] target/m68k: use gdb_get_reg helpers, Alex Bennée, 2020/01/14
- [PATCH v5 09/22] target/arm: prepare for multiple dynamic XMLs, Alex Bennée, 2020/01/14
- [PATCH v5 05/22] gdbstub: add helper for 128 bit registers, Alex Bennée, 2020/01/14
- [PATCH v5 04/22] gdbstub: move mem_buf to GDBState and use GByteArray, Alex Bennée, 2020/01/14
- [PATCH v5 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY, Alex Bennée, 2020/01/14
- [PATCH v5 02/22] gdbstub: stop passing GDBState * around and use global, Alex Bennée, 2020/01/14
- [PATCH v5 11/22] target/arm: default SVE length to 64 bytes for linux-user, Alex Bennée, 2020/01/14
- [PATCH v5 12/22] target/arm: generate xml description of our SVE registers, Alex Bennée, 2020/01/14
- Re: [PATCH v5 12/22] target/arm: generate xml description of our SVE registers,
Richard Henderson <=
- [PATCH v5 10/22] target/arm: explicitly encode regnum in our XML, Alex Bennée, 2020/01/14
- [PATCH v5 13/22] tests/tcg: add a configure compiler check for ARMv8.1 and SVE, Alex Bennée, 2020/01/14
- [PATCH v5 21/22] gdbstub: change GDBState.last_packet to GByteArray, Alex Bennée, 2020/01/14
- [PATCH v5 22/22] gdbstub: do not split gdb_monitor_write payload, Alex Bennée, 2020/01/14
- [PATCH v5 08/22] gdbstub: extend GByteArray to read register helpers, Alex Bennée, 2020/01/14