qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 14/86] arm:highbank: use memdev for RAM


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 14/86] arm:highbank: use memdev for RAM
Date: Wed, 15 Jan 2020 20:18:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/15/20 4:06 PM, Igor Mammedov wrote:
memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
   MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <address@hidden>
---
CC: address@hidden
CC: address@hidden
CC: address@hidden
---
  hw/arm/highbank.c | 10 ++++------
  1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
index 518d935..ac9de94 100644
--- a/hw/arm/highbank.c
+++ b/hw/arm/highbank.c
@@ -236,7 +236,6 @@ enum cxmachines {
   */
  static void calxeda_init(MachineState *machine, enum cxmachines machine_id)
  {
-    ram_addr_t ram_size = machine->ram_size;
      DeviceState *dev = NULL;
      SysBusDevice *busdev;
      qemu_irq pic[128];
@@ -247,7 +246,6 @@ static void calxeda_init(MachineState *machine, enum 
cxmachines machine_id)
      qemu_irq cpu_virq[4];
      qemu_irq cpu_vfiq[4];
      MemoryRegion *sysram;
-    MemoryRegion *dram;
      MemoryRegion *sysmem;
      char *sysboot_filename;
@@ -290,10 +288,8 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id)
      }
sysmem = get_system_memory();
-    dram = g_new(MemoryRegion, 1);
-    memory_region_allocate_system_memory(dram, NULL, "highbank.dram", 
ram_size);
      /* SDRAM at address zero.  */
-    memory_region_add_subregion(sysmem, 0, dram);
+    memory_region_add_subregion(sysmem, 0, machine->ram);
sysram = g_new(MemoryRegion, 1);
      memory_region_init_ram(sysram, NULL, "highbank.sysram", 0x8000,
@@ -387,7 +383,7 @@ static void calxeda_init(MachineState *machine, enum 
cxmachines machine_id)
/* TODO create and connect IDE devices for ide_drive_get() */ - highbank_binfo.ram_size = ram_size;
+    highbank_binfo.ram_size = machine->ram_size;
      /* highbank requires a dtb in order to boot, and the dtb will override
       * the board ID. The following value is ignored, so set it to -1 to be
       * clear that the value is meaningless.
@@ -430,6 +426,7 @@ static void highbank_class_init(ObjectClass *oc, void *data)
      mc->units_per_default_bus = 1;
      mc->max_cpus = 4;
      mc->ignore_memory_transaction_failures = true;
+    mc->default_ram_id = "highbank.dram";
  }
static const TypeInfo highbank_type = {
@@ -448,6 +445,7 @@ static void midway_class_init(ObjectClass *oc, void *data)
      mc->units_per_default_bus = 1;
      mc->max_cpus = 4;
      mc->ignore_memory_transaction_failures = true;
+    mc->default_ram_id = "highbank.dram";
  }
static const TypeInfo midway_type = {


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]