Re: [PATCH v3 80/86] hostmem: introduce "prealloc-threads" property

[BALATON Zoltan]

On Wed, 15 Jan 2020, Igor Mammedov wrote:
> diff --git a/backends/hostmem.c b/backends/hostmem.c
> index e773bdf..4c23c77 100644
> --- a/backends/hostmem.c
> +++ b/backends/hostmem.c
> @@ -223,7 +223,6 @@ static void host_memory_backend_set_prealloc(Object *obj, 
> bool value,
> {
>     Error *local_err = NULL;
>     HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> -    MachineState *ms = MACHINE(qdev_get_machine());
>
>     if (backend->force_prealloc) {
>         if (value) {
> @@ -243,7 +242,7 @@ static void host_memory_backend_set_prealloc(Object *obj, 
> bool value,
>         void *ptr = memory_region_get_ram_ptr(&backend->mr);
>         uint64_t sz = memory_region_size(&backend->mr);
>
> -        os_mem_prealloc(fd, ptr, sz, ms->smp.cpus, &local_err);
> +        os_mem_prealloc(fd, ptr, sz, backend->prealloc_threads, &local_err);
>         if (local_err) {
>             error_propagate(errp, local_err);
>             return;
> @@ -252,14 +251,45 @@ static void host_memory_backend_set_prealloc(Object *obj, 
> bool value,
>     }
> }
>
> +static void host_memory_backend_get_prealloc_threads(Object *obj, Visitor *v,
> +    const char *name, void *opaque, Error **errp)
> +{
> +    HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> +    visit_type_uint32(v, name, &backend->prealloc_threads, errp);
> +}
> +
> +static void host_memory_backend_set_prealloc_threads(Object *obj, Visitor *v,
> +    const char *name, void *opaque, Error **errp)
> +{
> +    HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> +    Error *local_err = NULL;
> +    uint32_t value;
> +
> +    visit_type_uint32(v, name, &value, &local_err);
> +    if (local_err) {
> +        goto out;
> +    }
> +    if (value <= 0) {
> +        error_setg(&local_err,
> +                   "property '%s' of %s doesn't take value '%d'",
> +                   name, object_get_typename(obj), value);
> +        goto out;
> +    }
> +    backend->prealloc_threads = value;
> +out:
> +    error_propagate(errp, local_err);
> +}
> +
> static void host_memory_backend_init(Object *obj)
> {
>     HostMemoryBackend *backend = MEMORY_BACKEND(obj);
>     MachineState *machine = MACHINE(qdev_get_machine());
>
> +    /* TODO: convert this compat properties */

Did you mean "convert these compat properties" or "convert this compat 
property"?

Regards,
BALATON Zoltan

>     backend->merge = machine_mem_merge(machine);
>     backend->dump = machine_dump_guest_core(machine);
>     backend->prealloc = mem_prealloc;
> +    backend->prealloc_threads = 1;
> }
>
> static void host_memory_backend_post_init(Object *obj)