[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 41/86] hw/hppa/machine: Correctly check the firmware is in PDC
From: |
Igor Mammedov |
Subject: |
[PATCH v2 41/86] hw/hppa/machine: Correctly check the firmware is in PDC range |
Date: |
Wed, 15 Jan 2020 16:06:56 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
The firmware has to reside in the PDC range. If the Elf file
expects to load it below FIRMWARE_START, it is incorrect,
regardless the RAM size.
Acked-by: Helge Deller <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Igor Mammedov <address@hidden>
---
hw/hppa/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 5d0de26..6775d87 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -155,7 +155,7 @@ static void machine_hppa_init(MachineState *machine)
qemu_log_mask(CPU_LOG_PAGE, "Firmware loaded at 0x%08" PRIx64
"-0x%08" PRIx64 ", entry at 0x%08" PRIx64 ".\n",
firmware_low, firmware_high, firmware_entry);
- if (firmware_low < ram_size || firmware_high >= FIRMWARE_END) {
+ if (firmware_low < FIRMWARE_START || firmware_high >= FIRMWARE_END) {
error_report("Firmware overlaps with memory or IO space");
exit(1);
}
--
2.7.4
- Re: [PATCH v2 37/86] arm:xlnx-zcu102: use memdev for RAM, (continued)
- [PATCH v2 40/86] cris:axis_dev88: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 43/86] hw/hppa/machine: Map the PDC memory region with higher priority, Igor Mammedov, 2020/01/15
- [PATCH v2 45/86] x86:microvm: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 44/86] hppa: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 38/86] s390x:s390-virtio-ccw: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 41/86] hw/hppa/machine: Correctly check the firmware is in PDC range,
Igor Mammedov <=
[PATCH v2 46/86] x86:pc: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 47/86] lm32:lm32_boards: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 49/86] m68k:an5206: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 48/86] lm32:milkymist: use memdev for RAM, Igor Mammedov, 2020/01/15