Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status

[ShihPo Hung]

On Tue, Jan 14, 2020 at 11:29 PM Richard Henderson <address@hidden> wrote:

On 1/14/20 12:13 AM, address@hidden wrote:
>      if (riscv_cpu_fp_enabled(env)) {
> -        *flags |= TB_FLAGS_MSTATUS_FS;
> +        *flags |= env->mstatus & MSTATUS_FS;
>      }

Note that riscv_cpu_fp_enabled is *also* testing env->mstatus, and that this
assignment can be made unconditional.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>

I'll send v3 that cleans up the patch accordingly.

Thanks for the review!