Re: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks

From:	no-reply
Subject:	Re: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks)
Date:	Tue, 14 Jan 2020 10:57:58 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks)
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
f83dc98 gdbstub: do not split gdb_monitor_write payload
7bf749e gdbstub: change GDBState.last_packet to GByteArray
2b88cdc tests/tcg/aarch64: add test-sve-ioctl guest-debug test
754f7ef tests/tcg/aarch64: add SVE iotcl test
c5d2630 tests/tcg/aarch64: add a gdbstub testcase for SVE registers
a80564a tests/guest-debug: add a simple test runner
edea27c configure: allow user to specify what gdb to use
c8e17aa tests/tcg/aarch64: userspace system register test
6f35e94 target/arm: don't bother with id_aa64pfr0_read for USER_ONLY
3bc14fe tests/tcg: add a configure compiler check for ARMv8.1 and SVE
2b904bc target/arm: generate xml description of our SVE registers
38d665c target/arm: default SVE length to 64 bytes for linux-user
8c07558 target/arm: explicitly encode regnum in our XML
37f8e9f target/arm: prepare for multiple dynamic XMLs
f13a871 gdbstub: extend GByteArray to read register helpers
3576ab6 target/m68k: use gdb_get_reg helpers
a25d2c6 target/arm: use gdb_get_reg helpers
d257321 gdbstub: add helper for 128 bit registers
718b8ce gdbstub: move mem_buf to GDBState and use GByteArray
e289622 gdbstub: move str_buf to GDBState and use GString
c29be44 gdbstub: stop passing GDBState * around and use global
dbb9c64 gdbstub: make GDBState static and have common init function

=== OUTPUT BEGIN ===
1/22 Checking commit dbb9c64bfad9 (gdbstub: make GDBState static and have 
common init function)
ERROR: braces {} are necessary for all arms of this statement
#128: FILE: gdbstub.c:2743:
+    if (!gdbserver_state.init)
[...]

ERROR: suspect code indent for conditional statements (2, 6)
#178: FILE: gdbstub.c:2962:
+  if (!gdbserver_state.init) {
       return;

ERROR: suspect code indent for conditional statements (2, 6)
#183: FILE: gdbstub.c:2966:
+  if (gdbserver_fd < 0 || gdbserver_state.fd < 0) {
       return;

total: 3 errors, 0 warnings, 384 lines checked

Patch 1/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/22 Checking commit c29be445fc79 (gdbstub: stop passing GDBState * around and 
use global)
WARNING: line over 80 characters
#754: FILE: gdbstub.c:1762:
+    if (target_memory_rw_debug(gdbserver_state.g_cpu, 
gdb_ctx->params[0].val_ull,

WARNING: line over 80 characters
#782: FILE: gdbstub.c:1785:
+    if (target_memory_rw_debug(gdbserver_state.g_cpu, 
gdb_ctx->params[0].val_ull,

WARNING: line over 80 characters
#1009: FILE: gdbstub.c:2022:
+    gdbserver_state.query_cpu = 
gdb_next_attached_cpu(gdbserver_state.query_cpu);

ERROR: line over 90 characters
#1370: FILE: gdbstub.c:2817:
+            put_buffer((uint8_t *)gdbserver_state.last_packet, 
gdbserver_state.last_packet_len);

ERROR: space required before the open parenthesis '('
#1388: FILE: gdbstub.c:2836:
+        switch(gdbserver_state.state) {

ERROR: line over 90 characters
#1420: FILE: gdbstub.c:2859:
+            } else if (gdbserver_state.line_buf_index >= 
sizeof(gdbserver_state.line_buf) - 1) {

ERROR: line over 90 characters
#1438: FILE: gdbstub.c:2872:
+            } else if (gdbserver_state.line_buf_index >= 
sizeof(gdbserver_state.line_buf) - 1) {

WARNING: line over 80 characters
#1448: FILE: gdbstub.c:2878:
+                gdbserver_state.line_buf[gdbserver_state.line_buf_index++] = 
ch ^ 0x20;

ERROR: line over 90 characters
#1464: FILE: gdbstub.c:2895:
+                if (gdbserver_state.line_buf_index + repeat >= 
sizeof(gdbserver_state.line_buf) - 1) {

WARNING: line over 80 characters
#1482: FILE: gdbstub.c:2905:
+                    memset(gdbserver_state.line_buf + 
gdbserver_state.line_buf_index,

ERROR: line over 90 characters
#1483: FILE: gdbstub.c:2906:
+                           
gdbserver_state.line_buf[gdbserver_state.line_buf_index - 1], repeat);

WARNING: line over 80 characters
#1518: FILE: gdbstub.c:2933:
+            if (gdbserver_state.line_csum != (gdbserver_state.line_sum & 
0xff)) {

ERROR: line over 90 characters
#1519: FILE: gdbstub.c:2934:
+                trace_gdbstub_err_checksum_incorrect(gdbserver_state.line_sum, 
gdbserver_state.line_csum);

WARNING: line over 80 characters
#1532: FILE: gdbstub.c:2943:
+                gdbserver_state.state = 
gdb_handle_packet(gdbserver_state.line_buf);

ERROR: line over 90 characters
#1647: FILE: gdbstub.c:3305:
+        qsort(gdbserver_state.processes, gdbserver_state.process_num, 
sizeof(gdbserver_state.processes[0]), pid_order);

total: 8 errors, 7 warnings, 1553 lines checked

Patch 2/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/22 Checking commit e28962275494 (gdbstub: move str_buf to GDBState and use 
GString)
WARNING: line over 80 characters
#150: FILE: gdbstub.c:1794:
+    memtohex(gdbserver_state.str_buf, gdb_ctx->mem_buf, 
gdb_ctx->params[1].val_ull);

WARNING: line over 80 characters
#323: FILE: gdbstub.c:2107:
+    g_string_printf(gdbserver_state.str_buf, "PacketSize=%x", 
MAX_PACKET_LENGTH);

total: 0 errors, 2 warnings, 422 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 718b8cea63b0 (gdbstub: move mem_buf to GDBState and use 
GByteArray)
5/22 Checking commit d257321c4329 (gdbstub: add helper for 128 bit registers)
6/22 Checking commit a25d2c6e41b2 (target/arm: use gdb_get_reg helpers)
ERROR: space required after that ',' (ctx:VxV)
#45: FILE: target/arm/helper.c:118:
+        return gdb_get_reg32(buf,vfp_get_fpcr(env));
                                 ^

total: 1 errors, 0 warnings, 28 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/22 Checking commit 3576ab615146 (target/m68k: use gdb_get_reg helpers)
8/22 Checking commit f13a8716a39f (gdbstub: extend GByteArray to read register 
helpers)
ERROR: "foo * bar" should be "foo *bar"
#196: FILE: include/exec/gdbstub.h:136:
+static inline uint8_t * gdb_get_reg_ptr(GByteArray *buf, int len)

total: 1 errors, 0 warnings, 913 lines checked

Patch 8/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/22 Checking commit 37f8e9f53873 (target/arm: prepare for multiple dynamic 
XMLs)
ERROR: line over 90 characters
#127: FILE: target/arm/gdbstub.c:159:
+    cpu->dyn_sysreg_xml.data.cpregs.keys = g_new(uint32_t, 
g_hash_table_size(cpu->cp_regs));

total: 1 errors, 0 warnings, 136 lines checked

Patch 9/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/22 Checking commit 8c07558a6f29 (target/arm: explicitly encode regnum in our 
XML)
11/22 Checking commit 38d665c42506 (target/arm: default SVE length to 64 bytes 
for linux-user)
12/22 Checking commit 2b904bc20798 (target/arm: generate xml description of our 
SVE registers)
WARNING: line over 80 characters
#107: FILE: target/arm/gdbstub.c:233:
+                g_string_append_printf(s, "<field name=\"%c\" 
type=\"vq%d%c%c\"/>",

WARNING: line over 80 characters
#311: FILE: target/arm/helper.c:7230:
+                                     arm_gen_dynamic_svereg_xml(cs, 
cs->gdb_num_regs),

total: 0 errors, 2 warnings, 299 lines checked

Patch 12/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/22 Checking commit 3bc14fe44309 (tests/tcg: add a configure compiler check 
for ARMv8.1 and SVE)
14/22 Checking commit 6f35e9494e5c (target/arm: don't bother with 
id_aa64pfr0_read for USER_ONLY)
15/22 Checking commit c8e17aa95fbf (tests/tcg/aarch64: userspace system 
register test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

ERROR: space required after that ',' (ctx:VxV)
#151: FILE: tests/tcg/aarch64/sysregs.c:115:
+    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#151: FILE: tests/tcg/aarch64/sysregs.c:115:
+    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#151: FILE: tests/tcg/aarch64/sysregs.c:115:
+    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:116:
+    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:116:
+    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:116:
+    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#154: FILE: tests/tcg/aarch64/sysregs.c:118:
+    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#154: FILE: tests/tcg/aarch64/sysregs.c:118:
+    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#154: FILE: tests/tcg/aarch64/sysregs.c:118:
+    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#157: FILE: tests/tcg/aarch64/sysregs.c:121:
+    get_cpu_reg_check_mask(id_aa64pfr0_el1,  _m(000f,000f,00ff,0011));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#157: FILE: tests/tcg/aarch64/sysregs.c:121:
+    get_cpu_reg_check_mask(id_aa64pfr0_el1,  _m(000f,000f,00ff,0011));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#157: FILE: tests/tcg/aarch64/sysregs.c:121:
+    get_cpu_reg_check_mask(id_aa64pfr0_el1,  _m(000f,000f,00ff,0011));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:122:
+    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0000,00f0));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:122:
+    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0000,00f0));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:122:
+    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0000,00f0));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#160: FILE: tests/tcg/aarch64/sysregs.c:124:
+    get_cpu_reg_check_mask(id_aa64dfr0_el1,  _m(0000,0000,0000,0006));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#160: FILE: tests/tcg/aarch64/sysregs.c:124:
+    get_cpu_reg_check_mask(id_aa64dfr0_el1,  _m(0000,0000,0000,0006));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#160: FILE: tests/tcg/aarch64/sysregs.c:124:
+    get_cpu_reg_check_mask(id_aa64dfr0_el1,  _m(0000,0000,0000,0006));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#167: FILE: tests/tcg/aarch64/sysregs.c:131:
+    get_cpu_reg_check_mask(midr_el1,         _m(0000,0000,ffff,ffff));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#167: FILE: tests/tcg/aarch64/sysregs.c:131:
+    get_cpu_reg_check_mask(midr_el1,         _m(0000,0000,ffff,ffff));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#167: FILE: tests/tcg/aarch64/sysregs.c:131:
+    get_cpu_reg_check_mask(midr_el1,         _m(0000,0000,ffff,ffff));
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#169: FILE: tests/tcg/aarch64/sysregs.c:133:
+    get_cpu_reg_check_mask(mpidr_el1,        _m(0000,0000,8000,0000));
                                                     ^

ERROR: space required after that ',' (ctx:VxV)
#169: FILE: tests/tcg/aarch64/sysregs.c:133:
+    get_cpu_reg_check_mask(mpidr_el1,        _m(0000,0000,8000,0000));
                                                          ^

ERROR: space required after that ',' (ctx:VxV)
#169: FILE: tests/tcg/aarch64/sysregs.c:133:
+    get_cpu_reg_check_mask(mpidr_el1,        _m(0000,0000,8000,0000));
                                                               ^

total: 24 errors, 1 warnings, 182 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/22 Checking commit edea27cd2689 (configure: allow user to specify what gdb 
to use)
17/22 Checking commit a80564a70fe7 (tests/guest-debug: add a simple test runner)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100755

ERROR: line over 90 characters
#72: FILE: tests/guest-debug/run-test.py:53:
+    gdb_cmd = "%s %s -ex 'target remote localhost:1234' -x %s" % (args.gdb, 
args.binary, args.test)

total: 1 errors, 1 warnings, 57 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit c5d26304d6ce (tests/tcg/aarch64: add a gdbstub testcase 
for SVE registers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 109 lines checked

Patch 18/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/22 Checking commit 754f7ef4cbac (tests/tcg/aarch64: add SVE iotcl test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 87 lines checked

Patch 19/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/22 Checking commit 2b88cdcae047 (tests/tcg/aarch64: add test-sve-ioctl 
guest-debug test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

total: 0 errors, 1 warnings, 103 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 7bf749e05baa (gdbstub: change GDBState.last_packet to 
GByteArray)
22/22 Checking commit f83dc98a8b00 (gdbstub: do not split gdb_monitor_write 
payload)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v5 17/22] tests/guest-debug: add a simple test runner, (continued)
- [PATCH v5 17/22] tests/guest-debug: add a simple test runner, Alex Bennée, 2020/01/14
  - Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner, Richard Henderson, 2020/01/15
  - Re: [PATCH v5 17/22] tests/guest-debug: add a simple test runner, Richard Henderson, 2020/01/15
- [PATCH v5 19/22] tests/tcg/aarch64: add SVE iotcl test, Alex Bennée, 2020/01/14
  - Re: [PATCH v5 19/22] tests/tcg/aarch64: add SVE iotcl test, Richard Henderson, 2020/01/15
- [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test, Alex Bennée, 2020/01/14
  - Re: [PATCH v5 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test, Richard Henderson, 2020/01/15
- [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers, Alex Bennée, 2020/01/14
  - Re: [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers, Richard Henderson, 2020/01/15
    - Re: [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers, Alex Bennée, 2020/01/16
- Re: [PATCH v5 00/22] gdbstub refactor and SVE support (+check-tcg tweaks), no-reply <=

Prev by Date: Re: [PATCH v12 07/13] virtio-iommu: Implement map/unmap
Next by Date: Re: [PATCH v2 0/4] qmp: Optionally run handlers in coroutines
Previous by thread: Re: [PATCH v5 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers
Next by thread: KVM call minutes for 2020-01-14
Index(es):
- Date
- Thread