[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions
From: |
Peter Xu |
Subject: |
Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions |
Date: |
Tue, 14 Jan 2020 13:49:39 -0500 |
On Tue, Jan 14, 2020 at 09:37:51AM +0100, Auger Eric wrote:
> > In all cases, I see that virtio_iommu_mr() is introduced but not used.
> > Would be good to put it into the patch where it's firstly used.
> OK fair enough, I will put the helper in the same patch as the user as
> you have requested that since the beginning ;-) The resulting patch may
> be huge. Just hope nobody will request me to split it back ;-)
We can wait for a few more days and see whether someone will have a
different answer before you start to squash things. :)
In all cases, I think we should get rid of the compiler trick at
least.
Thanks,
--
Peter Xu
- [PATCH v12 00/13] VIRTIO-IOMMU device, Eric Auger, 2020/01/09
- [PATCH v12 01/13] migration: Support QLIST migration, Eric Auger, 2020/01/09
- [PATCH v12 02/13] virtio-iommu: Add skeleton, Eric Auger, 2020/01/09
- [PATCH v12 03/13] virtio-iommu: Decode the command payload, Eric Auger, 2020/01/09
- [PATCH v12 04/13] virtio-iommu: Add the iommu regions, Eric Auger, 2020/01/09
- Re: [PATCH v12 04/13] virtio-iommu: Add the iommu regions, Peter Xu, 2020/01/13
- [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Eric Auger, 2020/01/09
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Peter Xu, 2020/01/13
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Auger Eric, 2020/01/14
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Peter Xu, 2020/01/14
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Auger Eric, 2020/01/15
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Peter Xu, 2020/01/15
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Auger Eric, 2020/01/15
- Re: [PATCH v12 05/13] virtio-iommu: Endpoint and domains structs and helpers, Auger Eric, 2020/01/15