[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v28 00/22] Add RX archtecture support
|
From: |
no-reply |
|
Subject: |
Re: [PATCH v28 00/22] Add RX archtecture support |
|
Date: |
Sun, 12 Jan 2020 05:33:08 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v28 00/22] Add RX archtecture support
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
026424c qemu-doc.texi: Add RX section.
43df918 BootLinuxConsoleTest: Test the RX-Virt machine
a569f77 Add rx-softmmu
8f12a47 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
02960cc hw/rx: Honor -accel qtest
9d25ce1 hw/rx: RX Target hardware definition
54ad24f hw/char: RX62N serial communication interface (SCI)
3d02ca6 hw/timer: RX62N internal timer modules
e0ba72f hw/intc: RX62N interrupt controller (ICUa)
5620d0b target/rx: Dump bytes for each insn during disassembly
f60e312 target/rx: Collect all bytes during disassembly
a0f74d3 target/rx: Emit all disassembly in one prt()
e652144 target/rx: Use prt_ldmi for XCHG_mr disassembly
7f42d50 target/rx: Replace operand with prt_ldmi in disassembler
bff2d28 target/rx: Disassemble rx_index_addr into a string
7e2a7a9 target/rx: RX disassembler
beab025 target/rx: CPU definition
2ef24ae target/rx: TCG helper
5269786 target/rx: TCG translation
7ef5260 hw/registerfields.h: Add 8bit and 16bit register macros
48a408f qemu/bitops.h: Add extract8 and extract16
940bb87 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 940bb8785a47 (MAINTAINERS: Add RX)
2/22 Checking commit 48a408ff9633 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 7ef5260d756d (hw/registerfields.h: Add 8bit and 16bit
register macros)
Use of uninitialized value in concatenation (.) or string at
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 52697860d4d7 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 2ef24aef4583 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit beab0251cc7e (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 588 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 7e2a7a9e4f15 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit bff2d286fd76 (target/rx: Disassemble rx_index_addr into a
string)
9/22 Checking commit 7f42d5046602 (target/rx: Replace operand with prt_ldmi in
disassembler)
10/22 Checking commit e65214408839 (target/rx: Use prt_ldmi for XCHG_mr
disassembly)
11/22 Checking commit a0f74d308947 (target/rx: Emit all disassembly in one
prt())
12/22 Checking commit f60e3125f8cf (target/rx: Collect all bytes during
disassembly)
13/22 Checking commit 5620d0b56a27 (target/rx: Dump bytes for each insn during
disassembly)
14/22 Checking commit e0ba72f7b818 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 3d02ca6d4ed0 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 54ad24f6d086 (hw/char: RX62N serial communication
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 401 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 9d25ce1b9164 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 480 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 02960ccac4dd (hw/rx: Honor -accel qtest)
19/22 Checking commit 8f12a475f061 (hw/rx: Restrict the RX62N microcontroller
to the RX62N CPU core)
20/22 Checking commit a569f776aadc (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 43df9187c8b7 (BootLinuxConsoleTest: Test the RX-Virt
machine)
22/22 Checking commit 026424ca5ceb (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- Re: [PATCH v28 17/22] hw/rx: RX Target hardware definition, (continued)
- [PATCH v28 22/22] qemu-doc.texi: Add RX section., Yoshinori Sato, 2020/01/12
- [PATCH v28 09/22] target/rx: Replace operand with prt_ldmi in disassembler, Yoshinori Sato, 2020/01/12
- [PATCH v28 05/22] target/rx: TCG helper, Yoshinori Sato, 2020/01/12
- [PATCH v28 07/22] target/rx: RX disassembler, Yoshinori Sato, 2020/01/12
- [PATCH v28 15/22] hw/timer: RX62N internal timer modules, Yoshinori Sato, 2020/01/12
- [PATCH v28 14/22] hw/intc: RX62N interrupt controller (ICUa), Yoshinori Sato, 2020/01/12
- [PATCH v28 04/22] target/rx: TCG translation, Yoshinori Sato, 2020/01/12
- Re: [PATCH v28 00/22] Add RX archtecture support,
no-reply <=
- Re: [PATCH v28 00/22] Add RX archtecture support, no-reply, 2020/01/12