qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/26] object: add extra sanity checks


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 01/26] object: add extra sanity checks
Date: Fri, 10 Jan 2020 20:18:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/10/20 4:30 PM, Marc-André Lureau wrote:
Type system checked that children class_size >= parent class_size, but
not instances. Fix that.

Signed-off-by: Marc-André Lureau <address@hidden>
---
  qom/object.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/qom/object.c b/qom/object.c
index 0d971ca897..8453e4ac91 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -303,6 +303,7 @@ static void type_initialize(TypeImpl *ti)
          int i;
g_assert(parent->class_size <= ti->class_size);
+        g_assert(parent->instance_size <= ti->instance_size);
          memcpy(ti->class, parent->class, parent->class_size);
          ti->class->interfaces = NULL;
          ti->class->properties = g_hash_table_new_full(


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]