Re: [PULL v2 6/9] configure: add GDBUS_CODEGEN

[Peter Maydell]

On Tue, 7 Jan 2020 at 16:40, Marc-André Lureau
<address@hidden> wrote:
>
> Hi
>
> On Tue, Jan 7, 2020 at 8:14 PM Peter Maydell <address@hidden> wrote:
> > I've just noticed that this seems to cause problems for
> > the NetBSD VM, because pkg-config reports a value for
> > gdbus_codegen which isn't an installed binary:
> >
> > localhost$ pkg-config --variable=gdbus_codegen gio-2.0
> > /usr/pkg/bin/gdbus-codegen
> > localhost$ ls /usr/pkg/bin/gdbus-codegen
> > ls: /usr/pkg/bin/gdbus-codegen: No such file or directory
> >
> > I think we need to install the 'gdbus-codegen' package in
> > our netbsd VM image.
> >
> > Maybe configure should check that it's actually got
> > an executable file before trying to use it?
>
> Sure, that should be enough:
>
> +    if [ ! -x "$gdbus_codegen" ]; then
> +        gdbus_codegen=
> +    fi
>
> I can send the patch.

Hi -- did you send this patch? I can't find it in my mail archive.

thanks
-- PMM