Re: [PULL 00/37] qom-ify serial and remove QDEV_PROP_PTR

[Peter Maydell]

On Tue, 7 Jan 2020 at 15:04, Marc-André Lureau
<address@hidden> wrote:
>
> The following changes since commit cdbc5c51c8755e4e9ce964fc92ba755e1c71a914:
>
>   Merge remote-tracking branch 'remotes/xtensa/tags/20200106-xtensa' into 
> staging (2020-01-07 10:31:07 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/prop-ptr-pull-request
>
> for you to fetch changes up to f0d753b1c1e6c334cd089be97a0eb9f1bc415559:
>
>   qdev/qom: remove some TODO limitations now that PROP_PTR is gone 
> (2020-01-07 17:24:29 +0400)
>
> ----------------------------------------------------------------
> Clean-ups: qom-ify serial and remove QDEV_PROP_PTR
>
> Hi,
>
> QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove
> me". In most cases, it can be easily replaced with QDEV_PROP_LINK when
> the pointer points to an Object.
>
> There are a few places where such substitution isn't possible. For
> those places, it seems reasonable to use a specific setter method
> instead, and keep the user_creatable = false. In other places,
> proper usage of qdev or other facilies is the solution.
>
> The serial code wasn't converted to qdev, which makes it a bit more
> archaic to deal with. Let's convert it first, so we can more easily
> embed it from other devices, and re-export some properties and drop
> QDEV_PROP_PTR usage.
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.

-- PMM