[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 08/14] testing: don't nest build for fp-test
From: |
Alex Bennée |
Subject: |
[PULL v2 08/14] testing: don't nest build for fp-test |
Date: |
Thu, 9 Jan 2020 14:18:52 +0000 |
Re-calling the main make is counter-productive and really messes up
with parallel builds. Just ensure we have built the pre-requisites
before we build the fp-test bits. If the user builds manually just
complain if the parent build hasn't got the bits we need.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 49e3b0d3194..7a767bf1148 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -969,7 +969,7 @@ FP_TEST_BIN=$(BUILD_DIR)/tests/fp/fp-test
# the build dir is created by configure
.PHONY: $(FP_TEST_BIN)
-$(FP_TEST_BIN):
+$(FP_TEST_BIN): config-host.h $(test-util-obj-y)
$(call quiet-command, \
$(MAKE) $(SUBDIR_MAKEFLAGS) -C $(dir $@) V="$(V)" $(notdir $@),
\
"BUILD", "$(notdir $@)")
diff --git a/tests/fp/Makefile b/tests/fp/Makefile
index 5a35e7c2109..56768ecfd2f 100644
--- a/tests/fp/Makefile
+++ b/tests/fp/Makefile
@@ -554,15 +554,13 @@ TF_OBJS_LIB += $(TF_OBJS_TEST)
BINARIES := fp-test$(EXESUF) fp-bench$(EXESUF)
-# everything depends on config-host.h because platform.h includes it
-all: $(BUILD_DIR)/config-host.h
- $(MAKE) $(BINARIES)
+# We require artefacts from the main build including config-host.h
+# because platform.h includes it. Rather than re-invoking the main
+# build we just error out if things aren't there.
+$(LIBQEMUUTIL) $(BUILD_DIR)/config-host.h:
+ $(error $@ missing, re-run parent build)
-$(LIBQEMUUTIL):
- $(MAKE) -C $(BUILD_DIR) libqemuutil.a
-
-$(BUILD_DIR)/config-host.h:
- $(MAKE) -C $(BUILD_DIR) config-host.h
+all: $(BUILD_DIR)/config-host.h $(BINARIES)
# libtestfloat.a depends on libsoftfloat.a, so specify it first
FP_TEST_LIBS := libtestfloat.a libsoftfloat.a $(LIBQEMUUTIL)
--
2.20.1
- [PULL v2 00/14] testing fixes and semihosting console support, Alex Bennée, 2020/01/09
- [PULL v2 02/14] tests/vm: update openbsd to release 6.6, Alex Bennée, 2020/01/09
- [PULL v2 01/14] hw/i386/x86-iommu: Add missing stubs, Alex Bennée, 2020/01/09
- [PULL v2 03/14] freebsd: use python37, Alex Bennée, 2020/01/09
- [PULL v2 04/14] travis.yml: avocado: Print logs of non-pass tests only, Alex Bennée, 2020/01/09
- [PULL v2 05/14] travis.yml: Detach build and test steps, Alex Bennée, 2020/01/09
- [PULL v2 06/14] travis.yml: duplicate before_script for MacOSX, Alex Bennée, 2020/01/09
- [PULL v2 07/14] travis.yml: install homebrew python for OS X, Alex Bennée, 2020/01/09
- [PULL v2 09/14] target/arm: remove unused EXCP_SEMIHOST leg, Alex Bennée, 2020/01/09
- [PULL v2 08/14] testing: don't nest build for fp-test,
Alex Bennée <=
- [PULL v2 13/14] tests/tcg: extract __semi_call into a header and expand, Alex Bennée, 2020/01/09
- [PULL v2 10/14] target/arm: only update pc after semihosting completes, Alex Bennée, 2020/01/09
- [PULL v2 14/14] tests/tcg: add user version of dumb-as-bricks semiconsole test, Alex Bennée, 2020/01/09
- [PULL v2 11/14] semihosting: add qemu_semihosting_console_inc for SYS_READC, Alex Bennée, 2020/01/09
- [PULL v2 12/14] tests/tcg: add a dumb-as-bricks semihosting console test, Alex Bennée, 2020/01/09
- Re: [PULL v2 00/14] testing fixes and semihosting console support, Peter Maydell, 2020/01/10