Re: [for-5.0 PATCH 02/11] qcow2: introduce icount field for snapshots

[Kevin Wolf]

Am 23.12.2019 um 10:46 hat Pavel Dovgalyuk geschrieben:
> From: Pavel Dovgalyuk <address@hidden>
> 
> This patch introduces the icount field for saving within the snapshot.
> It is required for navigation between the snapshots in record/replay mode.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> Acked-by: Kevin Wolf <address@hidden>

> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
> index af5711e533..aa9d447cda 100644
> --- a/docs/interop/qcow2.txt
> +++ b/docs/interop/qcow2.txt
> @@ -584,6 +584,10 @@ Snapshot table entry:
>  
>                      Byte 48 - 55:   Virtual disk size of the snapshot in 
> bytes
>  
> +                    Byte 56 - 63:   icount value which corresponds to
> +                                    the record/replay instruction count
> +                                    when the snapshot was taken
> +

In the context of the next patch, I noticed that we should probably also
mention that -1ULL means "invalid".

Kevin