[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/6] hw/i386/x86-iommu: Add missing stubs
From: |
Thomas Huth |
Subject: |
Re: [PATCH v1 1/6] hw/i386/x86-iommu: Add missing stubs |
Date: |
Tue, 7 Jan 2020 15:57:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 07/01/2020 14.53, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> In commit 6c730e4af9 we introduced a stub to build the MicroVM
> machine without Intel IOMMU. This stub is incomplete for the
> other PC machines. Add the missing stubs.
>
> Fixes: 6c730e4af9
> Reported-by: Travis-CI
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Wainer dos Santos Moschetta <address@hidden>
> Message-Id: <address@hidden>
> ---
> hw/i386/x86-iommu-stub.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/i386/x86-iommu-stub.c b/hw/i386/x86-iommu-stub.c
> index 03576cdccb4..c5ba077f9d1 100644
> --- a/hw/i386/x86-iommu-stub.c
> +++ b/hw/i386/x86-iommu-stub.c
> @@ -32,3 +32,12 @@ X86IOMMUState *x86_iommu_get_default(void)
> return NULL;
> }
>
> +bool x86_iommu_ir_supported(X86IOMMUState *s)
> +{
> + return false;
> +}
> +
> +IommuType x86_iommu_get_type(void)
> +{
> + abort();
> +}
I just ran into this issue today, too ... good to know that there is
already a patch :-)
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH v1 0/6] current testing/next (python and other fixes), Alex Bennée, 2020/01/07
- [PATCH v1 1/6] hw/i386/x86-iommu: Add missing stubs, Alex Bennée, 2020/01/07
- Re: [PATCH v1 1/6] hw/i386/x86-iommu: Add missing stubs,
Thomas Huth <=
- [PATCH v1 2/6] tests/vm: update openbsd to release 6.6, Alex Bennée, 2020/01/07
- [PATCH v1 4/6] travis.yml: avocado: Print logs of non-pass tests only, Alex Bennée, 2020/01/07
- [PATCH v1 3/6] freebsd: use python37, Alex Bennée, 2020/01/07
- [PATCH v1 6/6] travis: install homebrew python for OS X, Alex Bennée, 2020/01/07
- [PATCH v1 5/6] travis.yml: Detach build and test steps, Alex Bennée, 2020/01/07