Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> PIE is supported on many other hosts besides x86.
>
> The default for non-x86 is now the same as x86: pie is used
> if supported, and may be forced via --enable/--disable-pie.
>
> The original commit (40d6444e91c) said:
>
>   "Non-x86 are not changed, as they require TCG changes"
>
> but I think that's wrong -- there's nothing about PIE that
> affects TCG one way or another.
>
> Tested on aarch64 (bionic) and ppc64le (centos 7) hosts.
>
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

Also I double checked OpenBSD still worked:

Tested-by: Alex Bennée <address@hidden>

> ---
>  configure | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/configure b/configure
> index 30e3875c6b..99faf64a74 100755
> --- a/configure
> +++ b/configure
> @@ -2018,16 +2018,6 @@ if ! compile_prog "-Werror" "" ; then
>       "Thread-Local Storage (TLS). Please upgrade to a version that does."
>  fi
>  
> -if test "$pie" = ""; then
> -  case "$cpu-$targetos" in
> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
> -      ;;
> -    *)
> -      pie="no"
> -      ;;
> -  esac
> -fi
> -
>  if test "$pie" != "no" ; then
>    cat > $TMPC << EOF


-- 
Alex Bennée