Re: [PATCH v5 12/37] serial: start making SerialMM a sysbus device

[Peter Maydell]

On Fri, 20 Dec 2019 at 13:47, Marc-André Lureau
<address@hidden> wrote:
>
> Memory mapped serial device is in fact a sysbus device. The following
> patches will make use of sysbus facilities for resource and
> registration. In particular, "serial-mm: use sysbus facilities" will
> move internal serial realization to serial_mm_realize callback to
> follow qdev best practices.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> @@ -1068,30 +1080,56 @@ static const MemoryRegionOps serial_mm_ops[3] = {
>      },
>  };
>
> -SerialState *serial_mm_init(MemoryRegion *address_space,
> +SerialMM *serial_mm_init(MemoryRegion *address_space,
>                              hwaddr base, int it_shift,
>                              qemu_irq irq, int baudbase,
>                              Chardev *chr, enum device_endian end)
>  {

You might want to fix the indent on the other lines of
arguments here, but either way

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM