Re: [PATCH 096/104] virtiofsd: Reset O_DIRECT flag during file open

[Daniel P . Berrangé]

On Thu, Dec 12, 2019 at 04:38:56PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: Vivek Goyal <address@hidden>
> 
> If an application wants to do direct IO and opens a file with O_DIRECT
> in guest, that does not necessarily mean that we need to bypass page
> cache on host as well. So reset this flag on host.
> 
> If somebody needs to bypass page cache on host as well (and it is safe to
> do so), we can add a knob in daemon later to control this behavior.
> 
> I check virtio-9p and they do reset O_DIRECT flag.
> 
> Signed-off-by: Vivek Goyal <address@hidden>
> ---
>  tools/virtiofsd/passthrough_ll.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|