[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines |
|
Date: |
Tue, 7 Jan 2020 05:16:49 -0500 |
On Tue, Jan 07, 2020 at 11:01:48AM +0100, Paolo Bonzini wrote:
> On 31/12/19 19:32, Philippe Mathieu-Daudé wrote:
> > Only the PC-based machines use the fw_cfg device. In particular,
> > the MicroVM machine does not use it. Only compile/link it when
> > machines require it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> > Cc: Sergio Lopez <address@hidden>
> > ---
> > hw/i386/Makefile.objs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index 6ebb6d0cf0..48f2693546 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -5,7 +5,7 @@ obj-$(CONFIG_PC) += pc.o pc_sysfw.o
> > obj-$(CONFIG_I440FX) += pc_piix.o
> > obj-$(CONFIG_Q35) += pc_q35.o
> > obj-$(CONFIG_MICROVM) += microvm.o
> > -obj-y += fw_cfg.o
> > +obj-$(CONFIG_PC) += fw_cfg.o
> > obj-$(CONFIG_X86_IOMMU) += x86-iommu.o
> > obj-$(CONFIG_VTD) += intel_iommu.o
> > obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o
> >
>
> Ah no, this is hw/i386/fw_cfg.c; of course hw/nvram/fw_cfg.c has its own
> Kconfig symbol.
Sorry couldn't find it. Which symbol is that?
> Can you rename the file to pc-fwcfg.c and adjust the
> commit message?
>
> Paolo
Yea hw/i386/fw_cfg.c are helpers for use of fw cfg in pc,
it's not a fw cfg device as the commit message seems to
imply.
If there is a fw cfg symbol, would it be cleaner to make pc-fwcfg.c
depend on it?
--
MST