qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC


From: Paolo Bonzini
Subject: Re: [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC
Date: Tue, 7 Jan 2020 10:58:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 31/12/19 19:32, Philippe Mathieu-Daudé wrote:
> apic_eoi() calls ioapic_eoi_broadcast(), so APIC has to
> select the IOAPIC Kconfig.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: "Michael S. Tsirkin" <address@hidden>
> 
> RFC because I'm not sure the design is correct (meanwhile the fix is, 
> however).

Just add a comment like "# for ioapic_eoi_broadcast()".  If anybody
wants to drop it, they can add a stub.

Paolo

> ---
>  hw/intc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig
> index a189d6fedd..82748ae13d 100644
> --- a/hw/intc/Kconfig
> +++ b/hw/intc/Kconfig
> @@ -24,6 +24,7 @@ config APIC
>      bool
>      select MSI_NONBROKEN
>      select I8259
> +    select IOAPIC
>  
>  config ARM_GIC_KVM
>      bool
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]