[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] virtio: reset region cache when on queue deletion
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH 1/2] virtio: reset region cache when on queue deletion |
Date: |
Sun, 5 Jan 2020 07:21:57 -0500 |
On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1708480
> Fix leak of region reference that prevents complete
> device deletion on hot unplug.
>
> Signed-off-by: Yuri Benditovich <address@hidden>
I rebased this on top of my tree.
Got this:
commit f3dee6a062c1f4445768296ee39070bab9863372
Author: Yuri Benditovich <address@hidden>
Date: Thu Dec 26 06:36:48 2019 +0200
virtio: reset region cache when on queue deletion
https://bugzilla.redhat.com/show_bug.cgi?id=1708480
Fix leak of region reference that prevents complete
device deletion on hot unplug.
Signed-off-by: Yuri Benditovich <address@hidden>
Message-Id: <address@hidden>
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 95d8ff8508..7b861e0ca0 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -2344,6 +2344,7 @@ void virtio_delete_queue(VirtQueue *vq)
vq->handle_aio_output = NULL;
g_free(vq->used_elems);
vq->used_elems = NULL;
+ virtio_virtqueue_reset_region_cache(vq);
}
void virtio_del_queue(VirtIODevice *vdev, int n)
Can you confirm pls?
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Michael S. Tsirkin, 2020/01/01
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Yuri Benditovich, 2020/01/02
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Michael S. Tsirkin, 2020/01/05
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Yuri Benditovich, 2020/01/05
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Yuri Benditovich, 2020/01/06
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Michael S. Tsirkin, 2020/01/06
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Yuri Benditovich, 2020/01/06
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion, Yuri Benditovich, 2020/01/07
- Re: [PATCH 1/2] virtio: reset region cache when on queue deletion,
Michael S. Tsirkin <=