Re: [PATCH 005/104] virtiofsd: Add passthrough_ll

[Daniel P . Berrangé]

On Fri, Jan 03, 2020 at 12:15:35PM +0000, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (address@hidden) wrote:
> > On Thu, Dec 12, 2019 at 04:37:25PM +0000, Dr. David Alan Gilbert (git) 
> > wrote:
> > > From: "Dr. David Alan Gilbert" <address@hidden>
> > > 
> > > passthrough_ll is one of the examples in the upstream fuse project
> > > and is the main part of our daemon here.  It passes through requests
> > > from fuse to the underlying filesystem, using syscalls as directly
> > > as possible.
> > > 
> > > From libfuse fuse-3.8.0
> > > 
> > > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > > ---
> > >  tools/virtiofsd/passthrough_ll.c | 1338 ++++++++++++++++++++++++++++++
> > >  1 file changed, 1338 insertions(+)
> > >  create mode 100644 tools/virtiofsd/passthrough_ll.c
> > > 
> > > diff --git a/tools/virtiofsd/passthrough_ll.c 
> > > b/tools/virtiofsd/passthrough_ll.c
> > > new file mode 100644
> > > index 0000000000..5372d02934
> > > --- /dev/null
> > > +++ b/tools/virtiofsd/passthrough_ll.c
> > > @@ -0,0 +1,1338 @@
> > > +/*
> > > +  FUSE: Filesystem in Userspace
> > > +  Copyright (C) 2001-2007  Miklos Szeredi <address@hidden>
> > > +
> > > +  This program can be distributed under the terms of the GNU GPL.
> > 
> > I presume this mistake exists in upstream fuse GIT - missing GPL version
> > number info here.
> 
> Yes it is, see:
> https://github.com/libfuse/libfuse/blob/d735af94fa54a5555ce725f1d4e6b97b812b6603/example/passthrough_ll.c
> 
> And at the time that was added their COPYING file was GPL v2.
> 
> although they've since renamed COPYING to GPL2.txt but not updated
> the comments; but they added a LICENSE file.
> https://github.com/libfuse/libfuse/commit/e8bcd8461ce7dfdc7366f44bad8d855696e73c3b
> 
> > This is important to correct since we're moving code
> > from another repo and thus the COPYING file it is referring to on the
> > next line is ambiguous to the casual reader.
> > 
> > > +  See the file COPYING.
> > > +*/
> > 
> > With the GPL version info added:
> 
> So just change 'GNU GPL' to 'GNU GPL version 2' during the import?

Yes, or just  "GPLv2" is fine too. Ideally submit a patch to libfuse
upstream & then just copy the result.

> 
> >   Reviewed-by: Daniel P. Berrangé <address@hidden>
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|