Re: [PATCH v6 14/21] fuzz: Add target/fuzz makefile rules

[Stefan Hajnoczi]

On Fri, Nov 29, 2019 at 09:34:48PM +0000, Oleinik, Alexander wrote:
> diff --git a/Makefile.objs b/Makefile.objs
> index 9ff9b0c6f9..5478a554f6 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -86,10 +86,12 @@ common-obj-$(CONFIG_FDT) += device_tree.o
>  # qapi
>  
>  common-obj-y += qapi/
> +softmmu-obj-y = main.o
>  
> -softmmu-main-y = main.o
>  endif
>  
> +
> +
>  #######################################################################
>  # Target-independent parts used in system and user emulation
>  common-obj-y += cpus-common.o

Not urgent but as a general comment for future contributions:

It's nice to avoid churn in a patch series.  softmmu-main-y was
introduced in this patch series but now it's being removed again.  Can
this be consolidated with the earlier commit that introduced
softmmu-main-y?

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature