qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()


From: no-reply
Subject: Re: [PATCH] linux-user: Improve strace output for read() and getcwd()
Date: Thu, 21 Nov 2019 15:15:46 -0800 (PST)

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] linux-user: Improve strace output for read() and getcwd()
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e367aa3 linux-user: Improve strace output for read() and getcwd()

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#37: FILE: linux-user/strace.c:64:
+UNUSED static void print_encoded_string(abi_long addr, unsigned int maxlen, 
int last);

ERROR: storage class should be at the beginning of the declaration
#37: FILE: linux-user/strace.c:64:
+UNUSED static void print_encoded_string(abi_long addr, unsigned int maxlen, 
int last);

total: 1 errors, 1 warnings, 137 lines checked

Commit e367aa385965 (linux-user: Improve strace output for read() and getcwd()) 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]