[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 01/10] audio: add mixing-engine option (documentation)
From: |
Kővágó, Zoltán |
Subject: |
[PATCH v5 01/10] audio: add mixing-engine option (documentation) |
Date: |
Mon, 30 Sep 2019 22:28:54 +0200 |
This will allow us to disable mixeng when we use a decent backend.
Disabling mixeng have a few advantages:
* we no longer convert the audio output from one format to another, when
the underlying audio system would just convert it to a third format.
We no longer convert, only the underlying system, when needed.
* the underlying system probably has better resampling and sample format
converting methods anyway...
* we may support formats that the mixeng currently does not support (S24
or float samples, more than two channels)
* when using an audio server (like pulseaudio) different sound card
outputs will show up as separate streams, even if we use only one
backend
Disadvantages:
* audio capturing no longer works (wavcapture, and vnc audio extension)
* some backends only support a single playback stream or very picky
about the audio format. In this case we can't disable mixeng.
However mixeng is not removed, only made optional, so this shouldn't be
a big concern.
Signed-off-by: Kővágó, Zoltán <address@hidden>
---
Notes:
Changes from v1:
* renamed mixeng to mixing-engine
qapi/audio.json | 5 +++++
qemu-options.hx | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/qapi/audio.json b/qapi/audio.json
index 9fefdf5186..0996705954 100644
--- a/qapi/audio.json
+++ b/qapi/audio.json
@@ -11,6 +11,10 @@
# General audio backend options that are used for both playback and
# recording.
#
+# @mixing-engine: use QEMU's mixing engine to mix all streams inside QEMU. When
+# set to off, fixed-settings must be also off. Not every
backend
+# is compatible with the off setting (default on, since 4.2)
+#
# @fixed-settings: use fixed settings for host input/output. When off,
# frequency, channels and format must not be
# specified (default true)
@@ -31,6 +35,7 @@
##
{ 'struct': 'AudiodevPerDirectionOptions',
'data': {
+ '*mixing-engine': 'bool',
'*fixed-settings': 'bool',
'*frequency': 'uint32',
'*channels': 'uint32',
diff --git a/qemu-options.hx b/qemu-options.hx
index 2a04ca6ac5..3e50956f48 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -433,6 +433,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
" specifies the audio backend to use\n"
" id= identifier of the backend\n"
" timer-period= timer period in microseconds\n"
+ " in|out.mixing-engine= use mixing engine to mix streams
inside QEMU\n"
" in|out.fixed-settings= use fixed settings for host
audio\n"
" in|out.frequency= frequency to use with fixed settings\n"
" in|out.channels= number of channels to use with fixed
settings\n"
@@ -503,6 +504,11 @@ Identifies the audio backend.
Sets the timer @var{period} used by the audio subsystem in microseconds.
Default is 10000 (10 ms).
+@item in|out.mixing-engine=on|off
+Use QEMU's mixing engine to mix all streams inside QEMU. When off,
+@var{fixed-settings} must be off too. Not every backend is fully
+compatible with the off setting. Default is on.
+
@item in|out.fixed-settings=on|off
Use fixed settings for host audio. When off, it will change based on
how the guest opens the sound card. In this case you must not specify
--
2.23.0
- [PATCH v5 00/10] Audio: Mixeng-free 5.1/7.1 audio support, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 01/10] audio: add mixing-engine option (documentation),
Kővágó, Zoltán <=
- [PATCH v5 03/10] paaudio: get/put_buffer functions, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 02/10] audio: make mixeng optional, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 04/10] audio: support more than two channels in volume setting, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 07/10] usb-audio: do not count on avail bytes actually available, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 09/10] usbaudio: change playback counters to 64 bit, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 06/10] audio: basic support for multichannel audio, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 08/10] usb-audio: support more than two channels of audio, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 05/10] audio: replace shift in audio_pcm_info with bytes_per_frame, Kővágó, Zoltán, 2019/09/30
- [PATCH v5 10/10] paaudio: fix channel order for usb-audio 5.1 and 7.1 streams, Kővágó, Zoltán, 2019/09/30
- Re: [PATCH v5 00/10] Audio: Mixeng-free 5.1/7.1 audio support, no-reply, 2019/09/30