Re: [PATCH v25 00/22] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH v25 00/22] Add RX archtecture support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
24f4d54 qapi/machine.json: Add RX cpu.
7e3e17f BootLinuxConsoleTest: Test the RX-Virt machine
f538fda Add rx-softmmu
19f514a hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
5affaad hw/rx: Honor -accel qtest
67d2351 hw/rx: RX Target hardware definition
40c88de hw/char: RX62N serial communication interface (SCI)
f8431df hw/timer: RX62N internal timer modules
61a6575 hw/intc: RX62N interrupt controller (ICUa)
b85f52d target/rx: Dump bytes for each insn during disassembly
c102045 target/rx: Collect all bytes during disassembly
f3a06c1 target/rx: Emit all disassembly in one prt()
05337bc target/rx: Use prt_ldmi for XCHG_mr disassembly
75895d5 target/rx: Replace operand with prt_ldmi in disassembler
df09e83 target/rx: Disassemble rx_index_addr into a string
6887bf3 target/rx: RX disassembler
74e5bd0 target/rx: CPU definition
218b3d5 target/rx: TCG helper
08e90ec target/rx: TCG translation
cff8b93 hw/registerfields.h: Add 8bit and 16bit register macros
d88c506 qemu/bitops.h: Add extract8 and extract16
a243be5 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit a243be54034c (MAINTAINERS: Add RX)
2/22 Checking commit d88c5062c822 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit cff8b93d1631 (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 08e90ec1e2ff (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 218b3d519342 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 74e5bd0dacd9 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 6887bf307e62 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit df09e8393b92 (target/rx: Disassemble rx_index_addr into a 
string)
9/22 Checking commit 75895d54bad7 (target/rx: Replace operand with prt_ldmi in 
disassembler)
10/22 Checking commit 05337bccb7bf (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
11/22 Checking commit f3a06c13caa6 (target/rx: Emit all disassembly in one 
prt())
12/22 Checking commit c102045097dc (target/rx: Collect all bytes during 
disassembly)
13/22 Checking commit b85f52d3b01d (target/rx: Dump bytes for each insn during 
disassembly)
14/22 Checking commit 61a65750d4a8 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit f8431dfbfd31 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 40c88deed08d (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 67d235169cd2 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 5affaad35b6e (hw/rx: Honor -accel qtest)
19/22 Checking commit 19f514a11b89 (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/22 Checking commit f538fda2b988 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 59 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 7e3e17fec46a (BootLinuxConsoleTest: Test the RX-Virt 
machine)
22/22 Checking commit 24f4d547b80e (qapi/machine.json: Add RX cpu.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden