qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 22/26] qapi: Improve reporting of invalid 'if' further


From: Eric Blake
Subject: Re: [PATCH v2 22/26] qapi: Improve reporting of invalid 'if' further
Date: Fri, 27 Sep 2019 11:08:01 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 9/27/19 8:46 AM, Markus Armbruster wrote:
check_if()'s errors don't point to the offending part of the
expression.  For instance:

     tests/qapi-schema/alternate-branch-if-invalid.json:2: 'if' condition ' ' 
makes no sense

Other check_FOO() do, with the help of a @source argument.  Make
check_if() do that, too.  The example above improves to:

     tests/qapi-schema/alternate-branch-if-invalid.json:2: 'if' condition ' ' 
of 'data' member 'branch' makes no sense

Signed-off-by: Markus Armbruster <address@hidden>
---
Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]