Re: [PATCH v2 21/26] qapi: Avoid redundant definition references in erro

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 21/26] qapi: Avoid redundant definition references in erro

From:	Eric Blake
Subject:	Re: [PATCH v2 21/26] qapi: Avoid redundant definition references in error messages
Date:	Fri, 27 Sep 2019 10:03:54 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

On 9/27/19 8:46 AM, Markus Armbruster wrote:

Many error messages refer to the offending definition even though
they're preceded by an "in definition" line.  Rephrase them.

Signed-off-by: Markus Armbruster <address@hidden>
---


Comparing to v1 shows that you did indeed improve a few more messages.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 25/26] qapi: Improve reporting of redefinition, (continued)
- [PATCH v2 25/26] qapi: Improve reporting of redefinition, Markus Armbruster, 2019/09/27
- [PATCH v2 13/26] qapi: Make check_type()'s array case a bit more obvious, Markus Armbruster, 2019/09/27
- [PATCH v2 19/26] qapi: Improve reporting of invalid flags, Markus Armbruster, 2019/09/27
- [PATCH v2 07/26] qapi: Improve reporting of member name clashes, Markus Armbruster, 2019/09/27
- [PATCH v2 15/26] qapi: Inline check_name() into check_union(), Markus Armbruster, 2019/09/27
- [PATCH v2 11/26] qapi: Report invalid '*' prefix like any other invalid name, Markus Armbruster, 2019/09/27
- [PATCH v2 17/26] qapi: Move context-free checking to the proper place, Markus Armbruster, 2019/09/27
- [PATCH v2 09/26] qapi: Improve reporting of invalid name errors, Markus Armbruster, 2019/09/27
- [PATCH v2 12/26] qapi: Move check for reserved names out of add_name(), Markus Armbruster, 2019/09/27
- [PATCH v2 21/26] qapi: Avoid redundant definition references in error messages, Markus Armbruster, 2019/09/27
  - Re: [PATCH v2 21/26] qapi: Avoid redundant definition references in error messages, Eric Blake <=
- [PATCH v2 04/26] qapi: Prefix frontend errors with an "in definition" line, Markus Armbruster, 2019/09/27
- [PATCH v2 18/26] qapi: Improve reporting of invalid 'if' errors, Markus Armbruster, 2019/09/27
- [PATCH v2 08/26] qapi: Reorder check_FOO() parameters for consistency, Markus Armbruster, 2019/09/27
- [PATCH v2 05/26] qapi: Clean up member name case checking, Markus Armbruster, 2019/09/27
- [PATCH v2 16/26] qapi: Move context-sensitive checking to the proper place, Markus Armbruster, 2019/09/27
- [PATCH v2 23/26] qapi: Eliminate check_keys(), rename check_known_keys(), Markus Armbruster, 2019/09/27
- [PATCH v2 14/26] qapi: Plumb info to the QAPISchemaMember, Markus Armbruster, 2019/09/27
- [PATCH v2 24/26] qapi: Improve reporting of missing documentation comment, Markus Armbruster, 2019/09/27
- [PATCH v2 20/26] qapi: Improve reporting of missing / unknown definition keys, Markus Armbruster, 2019/09/27
- [PATCH v2 26/26] qapi: Improve source file read error handling, Markus Armbruster, 2019/09/27

Prev by Date: Re: [PATCH v2 27/33] spapr, xics, xive: Match signatures for XICS and XIVE KVM connect routines
Next by Date: Re: [PATCH v2 28/33] spapr: Remove SpaprIrq::init_kvm hook
Previous by thread: [PATCH v2 21/26] qapi: Avoid redundant definition references in error messages
Next by thread: [PATCH v2 04/26] qapi: Prefix frontend errors with an "in definition" line
Index(es):
- Date
- Thread