Re: [PATCH 18/22] iotests: Resolve TODOs in 041

[Vladimir Sementsov-Ogievskiy]

20.09.2019 18:28, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   tests/qemu-iotests/041 | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index d91f538276..ca126de3ff 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -921,8 +921,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>   
>           self.complete_and_wait(drive="job0")
>           self.assert_has_block_node("repair0", quorum_repair_img)
> -        # TODO: a better test requiring some QEMU infrastructure will be 
> added
> -        #       to check that this file is really driven by quorum
> +        self.vm.assert_block_path('quorum0/children.1', 'repair0')
>           self.vm.shutdown()
>           self.assertTrue(iotests.compare_images(quorum_img2, 
> quorum_repair_img),
>                           'target image does not match source after 
> mirroring')
> @@ -1074,9 +1073,7 @@ class TestRepairQuorum(iotests.QMPTestCase):
>   
>           self.complete_and_wait('job0')
>           self.assert_has_block_node("repair0", quorum_repair_img)
> -        # TODO: a better test requiring some QEMU infrastructure will be 
> added
> -        #       to check that this file is really driven by quorum
> -        self.vm.shutdown()
> +        self.vm.assert_block_path('quorum0/children.1', 'repair0')
>   
>   # Test mirroring with a source that does not have any parents (not even a
>   # BlockBackend)
> 


Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

-- 
Best regards,
Vladimir