[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/23] hw/sd/aspeed_sdhci: New device
|
From: |
Joel Stanley |
|
Subject: |
Re: [PATCH v2 02/23] hw/sd/aspeed_sdhci: New device |
|
Date: |
Thu, 26 Sep 2019 08:27:40 +0000 |
On Wed, 25 Sep 2019 at 14:33, Cédric Le Goater <address@hidden> wrote:
>
> From: Eddie James <address@hidden>
>
> The Aspeed SOCs have two SD/MMC controllers. Add a device that
> encapsulates both of these controllers and models the Aspeed-specific
> registers and behavior.
>
> Tested by reading from mmcblk0 in Linux:
> qemu-system-arm -machine romulus-bmc -nographic \
> -drive file=flash-romulus,format=raw,if=mtd \
> -device sd-card,drive=sd0 -drive file=_tmp/kernel,format=raw,if=sd,id=sd0
>
> Signed-off-by: Eddie James <address@hidden>
> Reviewed-by: Cédric Le Goater <address@hidden>
> [clg: - changed the controller MMIO window size to 0x1000
> - moved the MMIO mapping of the SDHCI slots at the SoC level
> - merged code to add SD drives on the SD buses at the machine level ]
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: Joel Stanley <address@hidden>
- [PATCH v2 00/23] aspeed: Add support for the AST2600 SoC, Cédric Le Goater, 2019/09/25
- [PATCH v2 01/23] aspeed/wdt: Check correct register for clock source, Cédric Le Goater, 2019/09/25
- [PATCH v2 02/23] hw/sd/aspeed_sdhci: New device, Cédric Le Goater, 2019/09/25
- Re: [PATCH v2 02/23] hw/sd/aspeed_sdhci: New device,
Joel Stanley <=
- [PATCH v2 03/23] hw: aspeed_scu: Add AST2600 support, Cédric Le Goater, 2019/09/25
- [PATCH v2 04/23] aspeed/timer: Introduce an object class per SoC, Cédric Le Goater, 2019/09/25
- [PATCH v2 05/23] aspeed/timer: Add support for control register 3, Cédric Le Goater, 2019/09/25
- [PATCH v2 06/23] aspeed/timer: Add AST2600 support, Cédric Le Goater, 2019/09/25
- [PATCH v2 07/23] aspeed/timer: Add support for IRQ status register on the AST2600, Cédric Le Goater, 2019/09/25
- [PATCH v2 08/23] aspeed/sdmc: Introduce an object class per SoC, Cédric Le Goater, 2019/09/25
- [PATCH v2 09/23] aspeed/sdmc: Add AST2600 support, Cédric Le Goater, 2019/09/25
- [PATCH v2 10/23] watchdog/aspeed: Introduce an object class per SoC, Cédric Le Goater, 2019/09/25