Re: [PATCH v3 18/33] tests/tcg: re-enable linux-test for ppc64abi32

[Philippe Mathieu-Daudé]

Hi Alex,

On 9/24/19 11:00 PM, Alex Bennée wrote:
> Now we have fixed the signal delivary bug we can remove this horrible

"delivery"

> hack from the system.
> 
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>

Can you reorder this patch after directly "target/ppc: fix signal
delivery for ppc64abi32"?

> 
> ---
> v2
>   - drop un-needed cflags
> ---
>  tests/tcg/multiarch/Makefile.target | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/tcg/multiarch/Makefile.target 
> b/tests/tcg/multiarch/Makefile.target
> index 6b1e30e2fec..657a04f802d 100644
> --- a/tests/tcg/multiarch/Makefile.target
> +++ b/tests/tcg/multiarch/Makefile.target
> @@ -12,14 +12,6 @@ VPATH              += $(MULTIARCH_SRC)
>  MULTIARCH_SRCS   =$(notdir $(wildcard $(MULTIARCH_SRC)/*.c))
>  MULTIARCH_TESTS  =$(MULTIARCH_SRCS:.c=)
>  
> -# FIXME: ppc64abi32 linux-test seems to have issues but the other basic 
> tests work
> -ifeq ($(TARGET_NAME),ppc64abi32)
> -BROKEN_TESTS = linux-test
> -endif
> -
> -# Update TESTS
> -TESTS                += $(filter-out $(BROKEN_TESTS), $(MULTIARCH_TESTS))
> -
>  #
>  # The following are any additional rules needed to build things
>  #
> @@ -39,3 +31,6 @@ run-test-mmap: test-mmap
>  run-test-mmap-%: test-mmap
>       $(call run-test, test-mmap-$*, $(QEMU) -p $* $<,\
>               "$< ($* byte pages) on $(TARGET_NAME)")
> +
> +# Update TESTS
> +TESTS += $(MULTIARCH_TESTS)
> 

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
(via make 'run-tcg-tests-ppc64abi32-linux-user')