|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 15/33] tests/docker: reduce scary warnings by cleaning up clean up |
Date: | Wed, 25 Sep 2019 11:55:25 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 9/24/19 2:00 PM, Alex Bennée wrote: > There was in the clean-up code caused by attempting to inspect images > which finished before we got there. Clean up the clean up code by: > > - only track the one instance at a time > - use --filter for docker ps instead of doing it by hand > - just call docker rm -f to be done with it > - use uuid.uuid4() for a random uid > > Signed-off-by: Alex Bennée <address@hidden> > > --- > v2 > - drop the try/except approach and be smarter > - use uuid4 as uuid1 can generate clashes in parallel builds > > fixup! tests/docker: reduce scary warnings by cleaning up clean up > --- > tests/docker/docker.py | 34 ++++++++++++++++------------------ > 1 file changed, 16 insertions(+), 18 deletions(-) Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |