[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 16/33] podman: fix command invocation
From: |
Thomas Huth |
Subject: |
Re: [PATCH v3 16/33] podman: fix command invocation |
Date: |
Wed, 25 Sep 2019 14:36:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 24/09/2019 23.00, Alex Bennée wrote:
> From: John Snow <address@hidden>
>
> Oops; there's no argv here.
>
> Signed-off-by: John Snow <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> Reviewed-by: Cleber Rosa <address@hidden>
> Tested-by: Cleber Rosa <address@hidden>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 3112892fdf5..31d8adf836e 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -332,7 +332,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
>
I ran into the same issue, too.
Reviewed-by: Thomas Huth <address@hidden>
Tested-by: Thomas Huth <address@hidden>
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, (continued)
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/25
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Alex Bennée, 2019/09/25
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Alex Bennée, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, John Snow, 2019/09/26
[PATCH v3 25/33] tests/docker: Add fedora-win10sdk-cross image, Alex Bennée, 2019/09/24
[PATCH v3 16/33] podman: fix command invocation, Alex Bennée, 2019/09/24
- Re: [PATCH v3 16/33] podman: fix command invocation,
Thomas Huth <=
[PATCH v3 19/33] tests/tcg: add float_madds test to multiarch, Alex Bennée, 2019/09/24
[PATCH v3 33/33] tests/docker: remove debian-powerpc-user-cross, Alex Bennée, 2019/09/24
[PATCH v3 20/33] tests/tcg: add generic version of float_convs, Alex Bennée, 2019/09/24
[PATCH v3 31/33] docker: remove unused debian-sid, Alex Bennée, 2019/09/24
Re: [PATCH v3 00/33] testing/next (docker,tcg, alpha ;-), no-reply, 2019/09/27