[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docker: fix uid maping with podman
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] docker: fix uid maping with podman |
Date: |
Wed, 25 Sep 2019 14:12:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 9/25/19 2:09 PM, Tomáš Golembiovský wrote:
> Commit 71ebbe09 refactored how uid mapping is performed when invoking
> container. It however introduced a bug in the flow when podman is used
> caused by wrong variable name.
Thanks Tomáš, but there is already a fix for this on the list:
https://www.mail-archive.com/address@hidden/msg647275.html
>
> Signed-off-by: Tomáš Golembiovský <address@hidden>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 29613afd48..bc7a470ca2 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -334,7 +334,7 @@ class Docker(object):
> cmd = [ "-u", str(uid) ] + cmd
> # podman requires a bit more fiddling
> if self._command[0] == "podman":
> - argv.insert(0, '--userns=keep-id')
> + cmd.insert(0, '--userns=keep-id')
>
> ret = self._do_check(["run", "--label",
> "com.qemu.instance.uuid=" + label] + cmd,
>