Re: [PATCH v2] qga: add command guest-get-devices for reporting VirtIO devices

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH v2] qga: add command guest-get-devices for reporting VirtIO 
devices

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
666d5ad qga: add command guest-get-devices for reporting VirtIO devices

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#67: FILE: qga/commands-win32.c:47:
+DEFINE_DEVPROPKEY(qga_DEVPKEY_NAME, 0xb725f130, 0x47ef, 0x101a, 0xa5, 0xf1, 
0x02,

WARNING: line over 80 characters
#69: FILE: qga/commands-win32.c:49:
+DEFINE_DEVPROPKEY(qga_DEVPKEY_Device_HardwareIds, 0xa45c254e, 0xdf1c, 0x4efd, 
0x80,

WARNING: line over 80 characters
#72: FILE: qga/commands-win32.c:52:
+DEFINE_DEVPROPKEY(qga_DEVPKEY_Device_DriverDate, 0xa8b865dd, 0x2e3d, 0x4094, 
0xad,

ERROR: spaces required around that '*' (ctx:WxV)
#81: FILE: qga/commands-win32.c:61:
+    CONST DEVPROPKEY *PropertyKey,
                      ^

ERROR: spaces required around that '*' (ctx:WxV)
#82: FILE: qga/commands-win32.c:62:
+    DEVPROPTYPE      *PropertyType,
                      ^

ERROR: spaces required around that '+' (ctx:VxV)
#126: FILE: qga/commands-win32.c:2288:
+    buffer = g_malloc(buffer_len+1);
                                 ^

ERROR: spaces required around that '+' (ctx:VxV)
#159: FILE: qga/commands-win32.c:2321:
+    hw_ids = g_new(char*, count+1);
                                ^

ERROR: "foo* bar" should be "foo *bar"
#205: FILE: qga/commands-win32.c:2367:
+        g_autofree char* vendor_id = NULL;

ERROR: "foo* bar" should be "foo *bar"
#206: FILE: qga/commands-win32.c:2368:
+        g_autofree char* device_id = NULL;

ERROR: spaces required around that '=' (ctx:VxV)
#224: FILE: qga/commands-win32.c:2386:
+        for (j=0; hw_ids[j] != NULL; j++) {
               ^

total: 7 errors, 3 warnings, 286 lines checked

Commit 666d5ad0d197 (qga: add command guest-get-devices for reporting VirtIO 
devices) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden