[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 22/33] configure: preserve PKG_CONFIG for subdir builds
From: |
Alex Bennée |
Subject: |
[PATCH v3 22/33] configure: preserve PKG_CONFIG for subdir builds |
Date: |
Tue, 24 Sep 2019 22:00:55 +0100 |
The slirp sub-module complains about not being able to find the glib
library on cross-compiles because it is using the default pkg-config
tool (which isn't installed in our cross-build docker images).
Preserve PKG_CONFIG in our host config and pass it down to slirp.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
Makefile | 6 +++++-
configure | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a0c1430b407..8da33595edd 100644
--- a/Makefile
+++ b/Makefile
@@ -510,7 +510,11 @@ capstone/all: .git-submodule-status
.PHONY: slirp/all
slirp/all: .git-submodule-status
- $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp
BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)"
RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
+ $(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp \
+ BUILD_DIR="$(BUILD_DIR)/slirp" \
+ PKG_CONFIG="$(PKG_CONFIG)" \
+ CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" \
+ CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
# Compatibility gunk to keep make working across the rename of targets
# for recursion, to be removed some time after 4.1.
diff --git a/configure b/configure
index 397bb476e19..542f6aea3f6 100755
--- a/configure
+++ b/configure
@@ -7302,6 +7302,7 @@ echo "OBJCOPY=$objcopy" >> $config_host_mak
echo "LD=$ld" >> $config_host_mak
echo "RANLIB=$ranlib" >> $config_host_mak
echo "NM=$nm" >> $config_host_mak
+echo "PKG_CONFIG=$pkg_config_exe" >> $config_host_mak
echo "WINDRES=$windres" >> $config_host_mak
echo "CFLAGS=$CFLAGS" >> $config_host_mak
echo "CFLAGS_NOPIE=$CFLAGS_NOPIE" >> $config_host_mak
--
2.20.1
- Re: [PATCH v3 30/33] docker: remove unused debian-ports, (continued)
- [PATCH v3 24/33] target/i386: Fix broken build with WHPX enabled, Alex Bennée, 2019/09/24
- [PATCH v3 14/33] tests/docker: remove python2.7 from debian9-mxe, Alex Bennée, 2019/09/24
- [PATCH v3 28/33] docker: removed unused debian8 partial image, Alex Bennée, 2019/09/24
- [PATCH v3 23/33] docs/devel: add "check-tcg" to testing.rst, Alex Bennée, 2019/09/24
- [PATCH v3 26/33] .shippable.yml: Build WHPX enabled binaries, Alex Bennée, 2019/09/24
- [PATCH v3 22/33] configure: preserve PKG_CONFIG for subdir builds,
Alex Bennée <=
- [PATCH v3 32/33] docker: move tests from python2 to python3, Alex Bennée, 2019/09/24
- [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Alex Bennée, 2019/09/24
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/25
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Alex Bennée, 2019/09/25
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Alex Bennée, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, Philippe Mathieu-Daudé, 2019/09/26
- Re: [PATCH v3 29/33] docker: remove 'deprecated' image definitions, John Snow, 2019/09/26