[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 23/25] Sockets: Fix error_append_hint usage
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v3 23/25] Sockets: Fix error_append_hint usage |
Date: |
Tue, 24 Sep 2019 23:09:00 +0300 |
If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro.
Otherwise hint will not be appended in case of errp == &fatal_err
(program will exit before error_append_hint() call). Fix such cases.
This commit (together with its neighbors) was generated by
git grep -l 'error_append_hint(errp' | while read f; do \
spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \
--in-place $f; done
and then
./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)"
(auto-msg was a file with this commit message)
Still, for backporting it may be more comfortable to use only the first
command and then do one huge commit.
Reported-by: Greg Kurz <address@hidden>
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
util/qemu-sockets.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 98ff3a1cce..fb21b78369 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -860,6 +860,7 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,
int num,
Error **errp)
{
+ ERRP_FUNCTION_BEGIN();
struct sockaddr_un un;
int sock, fd;
char *pathbuf = NULL;
@@ -935,6 +936,7 @@ err:
static int unix_connect_saddr(UnixSocketAddress *saddr, Error **errp)
{
+ ERRP_FUNCTION_BEGIN();
struct sockaddr_un un;
int sock, rc;
size_t pathlen;
--
2.21.0
- [PATCH v3 18/25] block: Fix error_append_hint usage, (continued)
- [PATCH v3 18/25] block: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 17/25] virtio-9p: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 21/25] QOM: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 20/25] cmdline: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 19/25] chardev: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 25/25] PVRDMA: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 24/25] nbd: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
- [PATCH v3 23/25] Sockets: Fix error_append_hint usage,
Vladimir Sementsov-Ogievskiy <=
- Re: [PATCH v3 00/25] error: auto propagated local_err, no-reply, 2019/09/25