[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/25] ARM TCG CPUs: Fix error_append_hint usage
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v3 08/25] ARM TCG CPUs: Fix error_append_hint usage |
Date: |
Tue, 24 Sep 2019 23:08:45 +0300 |
If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro.
Otherwise hint will not be appended in case of errp == &fatal_err
(program will exit before error_append_hint() call). Fix such cases.
This commit (together with its neighbors) was generated by
git grep -l 'error_append_hint(errp' | while read f; do \
spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \
--in-place $f; done
and then
./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)"
(auto-msg was a file with this commit message)
Still, for backporting it may be more comfortable to use only the first
command and then do one huge commit.
Reported-by: Greg Kurz <address@hidden>
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
hw/arm/msf2-soc.c | 1 +
hw/arm/virt.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/hw/arm/msf2-soc.c b/hw/arm/msf2-soc.c
index 008fd9327a..21e4bdfb72 100644
--- a/hw/arm/msf2-soc.c
+++ b/hw/arm/msf2-soc.c
@@ -85,6 +85,7 @@ static void m2sxxx_soc_initfn(Object *obj)
static void m2sxxx_soc_realize(DeviceState *dev_soc, Error **errp)
{
+ ERRP_FUNCTION_BEGIN();
MSF2State *s = MSF2_SOC(dev_soc);
DeviceState *dev, *armv7m;
SysBusDevice *busdev;
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index d74538b021..e79a46b0b3 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1793,6 +1793,7 @@ static char *virt_get_gic_version(Object *obj, Error
**errp)
static void virt_set_gic_version(Object *obj, const char *value, Error **errp)
{
+ ERRP_FUNCTION_BEGIN();
VirtMachineState *vms = VIRT_MACHINE(obj);
if (!strcmp(value, "3")) {
@@ -1825,6 +1826,7 @@ static char *virt_get_iommu(Object *obj, Error **errp)
static void virt_set_iommu(Object *obj, const char *value, Error **errp)
{
+ ERRP_FUNCTION_BEGIN();
VirtMachineState *vms = VIRT_MACHINE(obj);
if (!strcmp(value, "smmuv3")) {
--
2.21.0
- Re: [PATCH v3 02/25] hw/core/loader-fit: fix freeing errp in fit_load_fdt, (continued)
[PATCH v3 03/25] net/net: fix local variable shadowing in net_client_init, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 07/25] s390: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 08/25] ARM TCG CPUs: Fix error_append_hint usage,
Vladimir Sementsov-Ogievskiy <=
[PATCH v3 06/25] python: add commit-per-subsystem.py, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 09/25] PowerPC TCG CPUs: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 10/25] arm: Fix error_append_hint usage, Vladimir Sementsov-Ogievskiy, 2019/09/24
[PATCH v3 04/25] error: auto propagated local_err, Vladimir Sementsov-Ogievskiy, 2019/09/24